Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] 라이브러리 추가 설치 및 경고 해결 #151

Merged
merged 2 commits into from
Jul 9, 2024
Merged

[hotfix] 라이브러리 추가 설치 및 경고 해결 #151

merged 2 commits into from
Jul 9, 2024

Conversation

youz2me
Copy link
Member

@youz2me youz2me commented Jul 9, 2024

🔗 연결된 이슈

📄 작업 내용

  • KingFisher와 RxSwift 라이브러리 추가했습니다.
  • 최소 버전을 15.0으로 설정하면 일어나는 window 경고를 수정했습니다.
  • RxSwift 라이브러리 구현을 위해 ViewModelType 프로토콜을 추가했습니다.

@youz2me youz2me added 🛠️ fix 버그나 오류 해결시 사용 ⚙️ setting 프로젝트 관련 설정 변경 시 사용 💚 YouJin 저댄고?저댄고?저댄고?저댄고?저댄고? labels Jul 9, 2024
@youz2me youz2me requested review from JinUng41, hooni0918 and mmaybei July 9, 2024 12:05
@youz2me youz2me self-assigned this Jul 9, 2024
@youz2me youz2me linked an issue Jul 9, 2024 that may be closed by this pull request
[hotfix] 라이브러리 추가 설치 및 경고 해결 #150
Closed
2 tasks
hooni0918
hooni0918 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@hooni0918 hooni0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉 감사합니다 고맙습니다

JinUng41
JinUng41 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@JinUng41 JinUng41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

mmaybei
mmaybei approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@mmaybei mmaybei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이유진짜 감사합니다

@youz2me youz2me merged commit c119e30 into suyeon Jul 9, 2024
@JinUng41 JinUng41 deleted the hotfix/150-install-library-resolve-warning branch July 9, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinUng41 JinUng41 JinUng41 approved these changes

@hooni0918 hooni0918 hooni0918 approved these changes

@mmaybei mmaybei mmaybei approved these changes

Assignees

@youz2me youz2me

Labels
🛠️ fix 버그나 오류 해결시 사용 ⚙️ setting 프로젝트 관련 설정 변경 시 사용 💚 YouJin 저댄고?저댄고?저댄고?저댄고?저댄고?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[hotfix] 라이브러리 추가 설치 및 경고 해결
4 participants
@youz2me @JinUng41 @hooni0918 @mmaybei