Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next/719/20250213/v1 #12579

Merged
merged 5 commits into from
Feb 14, 2025
Merged

Conversation

victorjulien
Copy link
Member

This version of out Lua crate also supports cross compiling.
A no padding option is provided as a mode, as its a variant suitable
for encoding and decoding.

A padding optional function is added that is indifferent to padding
when decoding. This can be useful when you're not sure if padding
exists, and don't really care.
Export our base64 decoding and encoding functions to Lua.

Ticket: OISF#7074
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.72%. Comparing base (3831843) to head (c6d038b).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12579   +/-   ##
=======================================
  Coverage   80.72%   80.72%           
=======================================
  Files         929      930    +1     
  Lines      259062   259129   +67     
=======================================
+ Hits       209119   209187   +68     
+ Misses      49943    49942    -1     
Flag Coverage Δ
fuzzcorpus 56.94% <11.76%> (-0.02%) ⬇️
livemode 19.38% <0.00%> (-0.01%) ⬇️
pcap 44.15% <0.00%> (-0.04%) ⬇️
suricata-verify 63.41% <88.23%> (+0.03%) ⬆️
unittests 58.34% <21.05%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24721

Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@victorjulien victorjulien merged commit c6d038b into OISF:master Feb 14, 2025
60 checks passed
@victorjulien victorjulien deleted the next/719/20250213/v1 branch February 14, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants