configure: require minimum version of cbindgen to be 0.26.0 #12577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12577 +/- ##
==========================================
- Coverage 80.72% 80.71% -0.01%
==========================================
Files 929 929
Lines 259062 259062
==========================================
- Hits 209119 209112 -7
- Misses 49943 49950 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
0.10.0 doesn't work anymore. In some combinations 0.20.0 doesn't work either, however it does work in our CI jobs.
jasonish
force-pushed
the
cbindgen-min/v1
branch
from
83f90ff to
0824694
Compare
|
Back to draft. Pushing min version down to 0.20.0, while it does fail in some combinations with rustc, apparently it does work in all our CI jobs that still use 0.20.0 (or 0.24.x). |
|
Replaced by #12582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why, but 0.20.0 works on Fedora with Rust 1.75.0
installed via Rustup, but it does not work on Ubuntu 22.04 with Rust
installed by system packages.
However, cbindgen 0.26.0 works in both scenarios.