tls: more permissive empty data eof check #12574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12574 +/- ##
==========================================
- Coverage 80.72% 80.72% -0.01%
==========================================
Files 929 929
Lines 259062 259062
==========================================
- Hits 209119 209117 -2
- Misses 49943 49945 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
If not all data is ACK'd during the FIN session shutdown, the last calls to the parser can be with a non-NULL data pointer, but a input length of 0. This wasn't considered by the EOF check, which then lead to it being seen as an error. No event was raised, but the tls error stats were incremented. Bug: OISF#7554.
victorjulien
force-pushed
the
ssl-errors/v1
branch
from
49b2ea1 to
bfd3aeb
Compare
|
WARNING:
Pipeline 24722 |
inashivb
reviewed
Feb 15, 2025
inashivb
approved these changes
Feb 15, 2025
Merged
|
Merged in #12590, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not all data is ACK'd during the FIN session shutdown, the last calls to the parser can be with a non-NULL data pointer, but a input length of 0. This wasn't considered by the EOF check, which then lead to it being seen as an error. No event was raised, but the tls error stats were incremented.
SV_BRANCH=OISF/suricata-verify#2289
https://redmine.openinfosecfoundation.org/issues/7554