-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dpdk: collection of user-facing improvements v1.3 #12571
Open
lukashino
wants to merge
6
commits into
OISF:master
Choose a base branch
from
lukashino:feat/7374-7382-7373-crunch-v1.3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7380 Ticket: 7373
It turned out that having global (interface-specific) mempool that is shared by the threads of the interface is slower than having individual mempools per queue for each interface. The commit brings this change and should be user-invisible, the config setting remains still as a number of objects of all mempools summed (of that interface). Ticket: 7382
ICE card (Intel E810) was not receiving packets immediatelly after startup, Suricata workers would act as processing while it was not. This eliminates the problem by only continuing in the initialization if the link is already up. The setting can be turned off manually from the configuraiton file. Ticket: 7381
Ticket: 5838
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12571 +/- ##
==========================================
- Coverage 80.72% 80.69% -0.03%
==========================================
Files 929 930 +1
Lines 259062 259199 +137
==========================================
+ Hits 209119 209165 +46
- Misses 49943 50034 +91
Flags with carried forward coverage won't be shown. Click here to find out more. |
WARNING:
Pipeline 24716 |
Think this looks good. Does need a rebase to resolve merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of: #12531
Tickets:
https://redmine.openinfosecfoundation.org/issues/7373
https://redmine.openinfosecfoundation.org/issues/7382
https://redmine.openinfosecfoundation.org/issues/7381
https://redmine.openinfosecfoundation.org/issues/7380
https://redmine.openinfosecfoundation.org/issues/7374
https://redmine.openinfosecfoundation.org/issues/7373
https://redmine.openinfosecfoundation.org/issues/5838
v1.3:
Describe changes: