Fixups/v1 #12565
Merged
Fixups/v1 #12565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang-tidy did detect the -1 return value was not compatible with TmEcode enum.
These are set by our build-system, but some tools like cppcheck don't use that.
Helps tooling like cppcheck and clang-tidy.
Helps tooling like cppcheck, clang-tidy.
Helps code analyzers.
flow-queue.h included flow.h, but was also included by it.
Flagged by clang-tidy.
clang-tidy:
warning: integer to pointer cast pessimizes optimization opportunities
Since the returned code of -1 was never read, just return NULL.
victorjulien
force-pushed
the
fixups/v1
branch
from
0f51b06 to
d545b4d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12565 +/- ##
=======================================
Coverage 80.70% 80.71%
=======================================
Files 928 928
Lines 259013 259013
=======================================
+ Hits 209033 209056 +23
+ Misses 49980 49957 -23
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24695 |
Merged
|
Merged in #12569, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.