next/710/70x/20250210/v1 #12549
Closed
next/710/70x/20250210/v1 #12549
+223
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To optimize detection, and logging, to avoid going through all the live transactions when only a few were modified. Two boolean fields are added to the tx data: updated_tc and ts The app-layer parsers are now responsible to set these when needed, and the logging and detection uses them to skip transactions that were not updated. There may some more optimization remaining by when we set both updated_tc and updated_ts in functions returning a mutable transaction, by checking if all the callers are called in one direction only (request or response) Ticket: 7087 (cherry picked from commit b02557a) Conflicts: rust/src/applayer.rs rust/src/enip/enip.rs rust/src/ldap/ldap.rs src/app-layer-smtp.c
Ticket: 7495 We want to finish also if we tested all the expected protocols in mask, or if we tested even more. There can be one more protocol coming from pe0, which can be the protocol already found in the other direction. (cherry picked from commit b5094b0)
cherry-picked from commit 8ff80cb
Accepts valid characters as defined in RFC3261. cherry-picked from commit 7e993d5
The `is_version_char` function incorrectly allowed characters that are not part of the valid SIP version "SIP/2.0". For instance, 'HTTP/1.1' was mistakenly accepted as a valid SIP version, although it's not. This commit fixes the issue by updating the condition to strictly check for the correct version string. cherry-picked from commit 69f841c
Issue: 7467 Stream checksum validation no longer has a side effect of setting PKT_IGNORE_CHECKSUM and thus, no longer affects csum keyword checks. (cherry picked from commit 758da98)
Describe the change of behavior between the stream.checksum-validation setting and checksum-based rule keywords. (cherry picked from commit cfbf8fd)
victorjulien
requested review from
jufajardini,
catenacyber and
jasonish
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #12549 +/- ##
==============================================
+ Coverage 83.13% 83.24% +0.10%
==============================================
Files 922 922
Lines 261187 261304 +117
==============================================
+ Hits 217147 217527 +380
+ Misses 44040 43777 -263
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 24672 |
I agree this looks like something that doesn't belong there. |
Missed in initial review, even though conflicts were resolved. Would be nice to not have it, a bit misleading. |
|
Rejected after additional review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#2280