tool: rewrite suricatasc and suricatactl in rust - v10 #12540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a re-implementation of suricatasc program in Rust that attempts to be a 100% drop-in replacement.
As we have 2 Windows builds, do one using the release-style distribution file.
These should probably be removed even without the rewrite, and suricatasc has been installed as a proper program for many releases.
jasonish
requested review from
inashivb,
jufajardini and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12540 +/- ##
==========================================
+ Coverage 80.68% 80.71% +0.02%
==========================================
Files 925 926 +1
Lines 258914 258917 +3
==========================================
+ Hits 208914 208977 +63
+ Misses 50000 49940 -60
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24662 |
jufajardini
reviewed
Feb 10, 2025
|
Breaks make distcheck on the usual suspect in my CI: FreeBSD 14. |
|
I guess expected, but this does break my CI checks for unix socket that don't install anything and call the python script directly. Not sure if this is worth considering as part of a upgrade doc/process, but it doesn't make it transparent. |
Yeah, I guess its transparent for end-users, but not for those running from the source directory. There'll be a path change like |
Out of date Cargo.lock, I forgot to update it. Need to add a CI check for that! |
|
Continued at #12552:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #12504
Changes:
Replaces suricatasc and suricatactl with Rust variants removing python from our
distributed code (except suricata-update).
These now pass CI as some CI tests now use suricatasc where they didn't in the
previous version.
These should also be pure drop-in replacements.
Usually rewrites are a bad idea, but these are small, and in our core language
set, and may inspire us to write new more interesting tooling in the future,
like perhaps a plugin manager?
Ticket: https://redmine.openinfosecfoundation.org/issues/6287