ftp: begin conversion process to Rust. #12523
Open
+418
−222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the effort to convert the FTP/FTPDATA parser to rust, move the enums from C to rust.
Issue: 4082 This command moves the FtpTransferCmd and FtpCommand to Rust. Due to the way commands are noted in the transactions, the logic in the sticky buffer ftp.command and the ftp json output functions was updated.
Issue: 4082 Move the configuration file handling to Rust. These changes will no longer terminate Suricata when there's an invalid value for ftp.memcap. Like earlier Suricata releases, an error message is logged "Invalid value <value> for ftp.memcap" but Suricata will no longer terminate execution. It will use a default value of "0" instead.
jlucovsky
requested review from
jasonish,
jufajardini and
victorjulien
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12523 +/- ##
==========================================
- Coverage 80.70% 80.69% -0.01%
==========================================
Files 925 926 +1
Lines 258914 258968 +54
==========================================
+ Hits 208949 208976 +27
- Misses 49965 49992 +27
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24543 |
jasonish
reviewed
Feb 3, 2025
| *memcap = v; | ||
| SCLogConfig!("FTP memcap: {}", v); | ||
| } else { | ||
| SCLogError!("Invalid value {} for ftp.memcap", val); |
There was a problem hiding this comment.
For these can we add a bit more info..
Invalid value {} for ftp.memcap, will use default of ??
And since nothing errors out, perhaps a warning instead?
There was a problem hiding this comment.
Good idea. I'll add an s-v test to validate the parsing and warning message output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #12522
ftp: Partial conversion of the FTP protocol parser to Rust.
This PR represents partial completion of issue 4082.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/4082
Describe changes:
Updates:
SCLogNoticecall on the output path withSCLogDebugBehavioral change
Previous versions of Suricata terminated execution if
ftp.memcapcontained an invalid value. An error message was displayed before exiting. The changes in this PR continue to print the error message in this case; instead of terminating Suricata, Suricata will continue execution and use a value of0forftp.memcap. This is noted in the upgrade notes.Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=