Ilya bakhtin/dns dcerpc reversed v5 #12503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12503 +/- ##
=======================================
Coverage 80.56% 80.57%
=======================================
Files 925 925
Lines 259292 259287 -5
=======================================
+ Hits 208906 208922 +16
+ Misses 50386 50365 -21
Flags with carried forward coverage won't be shown. Click here to find out more. |
Several additional checks are added to the probing parser to avoid false detection of DNS as DCERPC Ticket - 7111
Protocol detection code is simplified. Removed dependency on explicit alproto constants from the common part of code that must not be aware of the each specific protocol features. Ticket - 7111
catenacyber
force-pushed
the
ilya-bakhtin/dns-dcerpc-reversed-v5
branch
from
d2c55a3 to
317b93c
Compare
|
Information: QA ran without warnings. Pipeline 24434 |
|
WARNING:
Pipeline 24440 |
|
Information: QA ran without warnings. Pipeline 24442 |
victorjulien
approved these changes
Jan 30, 2025
Merged
|
Merged in #12514, thanks! |
|
Thanks @ilya-bakhtin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7111
Describe changes:
It previously contained a bug that combined with a false positive in DCERPC resulted in incorrect reporting of DNS flow direction.
SV_BRANCH=OISF/suricata-verify#2266
Rebase of #12134 that I approve of to get a clean green CI