Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applayer plugin 5053 v2.6 #11473

Closed

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053

Describe changes:

  • get ready to use dynamic number of app-layer protos for some global arrays : run modes and output

Small PR good in itself.

#11373 next round
Based on #11429 with unix socket run mode crash fix, and improvement for run modes, where the global variable just become a local stack allocated one, propagated to the callees

Still more work to do : I guess stack allocated arrays are fine, but the global variables cf git grep '\[ALPROTO_MAX' in

  • app-layer-detect-proto.c
  • app-layer-frames.c
  • app-layer-parser.c
  • app-layer-protos.c
  • app-layer.c
    need to be allocated and freed, with taking care of the initialization order, so that we know ALPROTO_MAX final value...

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.57%. Comparing base (090079c) to head (866f9b8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11473      +/-   ##
==========================================
+ Coverage   82.52%   82.57%   +0.04%     
==========================================
  Files         938      938              
  Lines      248297   248318      +21     
==========================================
+ Hits       204917   205037     +120     
+ Misses      43380    43281      -99     
Flag Coverage Δ
fuzzcorpus 60.71% <87.23%> (+0.26%) ⬆️
livemode 18.72% <82.97%> (+0.02%) ⬆️
pcap 43.75% <89.36%> (-0.03%) ⬇️
suricata-verify 61.55% <93.61%> (+0.01%) ⬆️
unittests 59.43% <70.21%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@catenacyber catenacyber marked this pull request as draft July 10, 2024 21:27
@catenacyber catenacyber force-pushed the applayer-plugin-5053-v2.6 branch from d9a0d6c to 5f3cf58 Compare July 10, 2024 21:31
@suricata-qa
Copy link

WARNING:

ERROR: QA failed on SURI_TLPW1_suri_time.

ERROR: QA failed on SURI_TLPR1_suri_time.

ERROR: QA failed on SURI_TLPR1_alerts_cmp.

field baseline test %
SURI_TLPW2_single_stats_chk
.uptime 776 803 103.48%
SURI_TLPW1_stats_chk
.uptime 178 185 103.93%
.app_layer.tx.ftp 188 179 95.21%
SURI_TLPR1_stats_chk
.uptime 642 847 131.93%
.app_layer.tx.ftp 101030 87644 86.75%
.app_layer.tx.smtp 602007 375156 62.32%
.app_layer.error.http.parser 700 798 114.0%
IPS_AFP_stats_chk
.app_layer.tx.smtp 74520 37800 50.72%
TREX_GENERIC_stats_chk
.app_layer.tx.smtp 29494 14747 50.0%

Pipeline 21472

@catenacyber catenacyber force-pushed the applayer-plugin-5053-v2.6 branch from 5f3cf58 to 9e5a880 Compare July 11, 2024 07:36
@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPW2_autofp_suri_time.

field baseline test %
SURI_TLPW2_autofp_stats_chk
.uptime 137 143 104.38%

Pipeline 21510

@catenacyber
Copy link
Contributor Author

Continues in #11507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants