-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applayer plugin 5053 v2.6 #11473
Applayer plugin 5053 v2.6 #11473
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11473 +/- ##
==========================================
+ Coverage 82.52% 82.57% +0.04%
==========================================
Files 938 938
Lines 248297 248318 +21
==========================================
+ Hits 204917 205037 +120
+ Misses 43380 43281 -99
Flags with carried forward coverage won't be shown. Click here to find out more. |
d9a0d6c
to
5f3cf58
Compare
Ticket: 5053
Ticket: 5053
WARNING: ERROR: QA failed on SURI_TLPW1_suri_time. ERROR: QA failed on SURI_TLPR1_suri_time. ERROR: QA failed on SURI_TLPR1_alerts_cmp.
Pipeline 21472 |
5f3cf58
to
9e5a880
Compare
Information: ERROR: QA failed on SURI_TLPW2_autofp_suri_time.
Pipeline 21510 |
Continues in #11507 |
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053
Describe changes:
Small PR good in itself.
#11373 next round
Based on #11429 with unix socket run mode crash fix, and improvement for run modes, where the global variable just become a local stack allocated one, propagated to the callees
Still more work to do : I guess stack allocated arrays are fine, but the global variables cf
git grep '\[ALPROTO_MAX'
inneed to be allocated and freed, with taking care of the initialization order, so that we know
ALPROTO_MAX
final value...