parse/size: support IEEE 1541 size units v2 #11471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce KiB, MiB and GiB. They are case sensitive as a lower case 'b' means bits in the IEEE 1541 scheme. KiB = 1024 MiB = 1048576 GiB = 1073741824 Ticket: OISF#1457.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11471 +/- ##
==========================================
+ Coverage 82.52% 82.55% +0.02%
==========================================
Files 938 938
Lines 248297 248321 +24
==========================================
+ Hits 204917 205006 +89
+ Misses 43380 43315 -65
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 21483 |
inashivb
reviewed
Jul 12, 2024
There was a problem hiding this comment.
Looking good. Some nits inline and missing small updates to the configuration file below.
Config options:
types.alert.payload-buffer-size: 4kbtypes.frame.payload-buffer-size: 4kbdatasets.defaults.memcap: 100mb
Config comments:
the reserved memory (memcap) for flows is 32MBThe memcap can be specified in kb, mb, gbreassemble 1mb into a streamDefault is unlimited, values can be 64mb
| @@ -410,7 +410,7 @@ outputs: | |||
|
|
|||
| # File size limit. Can be specified in kb, mb, gb. Just a number | |||
There was a problem hiding this comment.
nit: comment still says kb, mb, gb..
| # string-log-limit: 1kb # limit size of logged strings in bytes. | ||
| # Can be specified in kb, mb, gb. Just a number | ||
| # string-log-limit: 1KiB # limit size of logged strings in bytes. | ||
| # Can be specified in KiB, MiB, GiB. Just a number | ||
| # is parsed as bytes. Default is 1KB. |
Closed
|
Replaced by #11485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SV_BRANCH=OISF/suricata-verify#1971
https://redmine.openinfosecfoundation.org/issues/1457