Pcap perf/v6 #11464
Closed
Pcap perf/v6 #11464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original limit was due to a specific data structure.
Inspired by a recent Zeek blog post, this could speed up PCAP processing by a few percent. Ticket: OISF#7155.
Make optional through `pcap-file.buffer-size` config option. Make sure to check through configure. Ticket: OISF#7155.
Allows easy specification of buffer size on the commandline. Ticket: OISF#7155.
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11464 +/- ##
==========================================
+ Coverage 82.52% 82.54% +0.01%
==========================================
Files 938 938
Lines 248297 248328 +31
==========================================
+ Hits 204917 204985 +68
+ Misses 43380 43343 -37
Flags with carried forward coverage won't be shown. Click here to find out more. |
jasonish
approved these changes
Jul 11, 2024
|
Information: QA ran without warnings. Pipeline 21486 |
inashivb
requested review from
inashivb and
a team
and removed request for
inashivb
Closed
|
replaced by #11486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redmine.openinfosecfoundation.org/issues/7155
Rebase #11457, fix review comment.