-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: update ips-state-1 test - v2 #1496
Conversation
This test indicated that there were FP drops for http and that another check was failing, but currently the test passes.
Looks reasonable. Disclaimer : I have never used this flow.action field |
It can, check for instance https://github.com/OISF/suricata-verify/blob/master/tests/exception-policy-midstream-02/test.yaml#L22
I'm afraid we don't have anything directly, we mention it when explaining Exception Policies, but it's rather indirect: https://docs.suricata.io/en/latest/configuration/exception-policies.html#auto |
Thanks. What means |
From what I understand, |
So, my feeling from someone who does not know this part is that |
Thanks for helping in figuring out this one! |
Can I help further here ? |
Thanks, I don't know exactly what to do with this check. I've created a new PR with more checks, and kepts the flow.action check, still unsure if this is a possible bug to investigate or not... |
Follow by: #1781 |
This test indicated that there were FP drops for http and that another check was failing, but currently the test passes.
Previous PR: #1227
Changes from previous PR:
-- make test fail again, by checking for
flow.action: drop
fortls
flowQuestion: do we expect to see
flow.action
set todrop
here?