Skip to content

Commit

Permalink
hot fix for result table creation
Browse files Browse the repository at this point in the history
  • Loading branch information
jreps committed Aug 21, 2024
1 parent 3827075 commit 1dfc46b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ Package: PatientLevelPrediction
Type: Package
Title: Developing patient level prediction using data in the OMOP Common Data
Model
Version: 6.3.8
Date: 2024-04-26
Version: 6.3.9
Date: 2024-08-21
Authors@R: c(
person("Jenna", "Reps", email = "[email protected]", role = c("aut", "cre")),
person("Martijn", "Schuemie", role = c("aut")),
Expand Down
5 changes: 4 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
PatientLevelPrediction 6.3.9
======================
- Hotfix adding schema to DatabaseConnector::getTableNames when creating results tables

PatientLevelPrediction 6.3.8
======================
- Add support for R4.4
Expand All @@ -19,7 +23,6 @@ runMultiplePlp
- Speed up population generation when subjectId's are distinct
- Fix bug when population was still generated when provided to runPlp


PatientLevelPrediction 6.3.6
======================
- fix bug with ohdsi shiny modules version check (issue 415)
Expand Down
2 changes: 1 addition & 1 deletion R/uploadToDatabase.R
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ createPlpResultTables <- function(
conn <- DatabaseConnector::connect(connectionDetails = connectionDetails)
on.exit(DatabaseConnector::disconnect(conn))

tablesExists <- sum(tolower(getPlpResultTables()) %in% tolower(DatabaseConnector::getTableNames(conn)))
tablesExists <- sum(tolower(getPlpResultTables()) %in% tolower(DatabaseConnector::getTableNames(connection = conn, databaseSchema = resultSchema)))
tablesExists <- tablesExists == length(getPlpResultTables())

if(!tablesExists){
Expand Down

0 comments on commit 1dfc46b

Please sign in to comment.