Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Singleton Tests #3163

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Port Singleton Tests #3163

wants to merge 5 commits into from

Conversation

WanjohiSammy
Copy link
Contributor

@WanjohiSammy WanjohiSammy commented Jan 9, 2025

Issues

This pull request fixes #xxx.

Description

Port Singleton Tests from WCF to use AspNetCoreOData

Checklist (Uncheck if it is not completed)

  • Test cases added
  • Build and test with one-click build and test script passed

Additional work necessary

If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 11 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • test/EndToEndTests/Tests/Client/Microsoft.OData.Client.E2E.Tests/Common/Client/Default/DefaultServiceCsdl.xml: Language not supported
  • test/EndToEndTests/Tests/Client/Microsoft.OData.Client.E2E.Tests/Common/Server/Default/DefaultEdmModel.cs: Evaluated as low risk
  • test/EndToEndTests/Common/Microsoft.OData.Client.E2E.TestCommon/Helpers/ODataValueAssertEqualHelper.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)

test/EndToEndTests/Tests/Client/Microsoft.OData.Client.E2E.Tests/SingletonTests/Tests/SingletonUpdateTests.cs:96

  • Add a check to ensure that 'properties' is not empty before using it.
var properties = new[] { new ODataProperty { Name = "City", Value = cities[mimeType] } };
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant