Consistently manage admin acks #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We eventually require the admin-acks ConfigMap [1] in all of our clusters. Rather than duplicating it everywhere, including it in base and use a configMapGenerator to populate it in each overlay. Part-of: nerc-project/operations#285 [1]: https://docs.openshift.com/container-platform/4.14/updating/preparing_for_updates/updating-cluster-prepare.html#update-preparing-ack_updating-cluster-prepare
larsks
force-pushed
the
fix/admin-acks
branch
from
e0d9fa3 to
31a3e4c
Compare
schwesig
approved these changes
Nov 28, 2023
aabaris
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We eventually require the admin-acks ConfigMap 1 in all of our clusters. Rather than duplicating it everywhere, including it in base and use a configMapGenerator to populate it in each overlay.
Part-of: nerc-project/operations#285