[15.0][IMP] stock_picking_product_barcode_report: Remove space under barcode #559
+25
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosdauden
suggested changes
Nov 21, 2023
| @@ -22,7 +22,8 @@ def report_barcode( | |||
| ): | |||
| if type == "gs1_128": | |||
| Gs1_128 = barcode.get_barcode_class("gs1_128") | |||
| gs1_182 = Gs1_128(str(value), writer=SVGWitoutTextWriter()) | |||
| writer = SVGWitoutTextWriter(module_max_height=height) | |||
| gs1_182 = Gs1_128(str(value), writer=writer) | |||
There was a problem hiding this comment.
Looks like a typo
Suggested change
| gs1_182 = Gs1_128(str(value), writer=writer) | |
| gs1_128 = Gs1_128(str(value), writer=writer) |
Change next line too
CarlosRoca13
force-pushed
the
15.0-IMP-stock_picking_product_barcode_report
branch
from
5f0ea28 to
ae08997
Compare
sergio-teruel
approved these changes
Nov 22, 2023
carlosdauden
approved these changes
Nov 22, 2023
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 3870743. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT46018
ping @sergio-teruel @carlosdauden