[17.0][MIG] mail_debrand #1257
Closed
[17.0][MIG] mail_debrand #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @guestisp |
guestisp
changed the title
|
Whats the status here? |
|
Please include #1272 |
|
/ocabot migration mail_debrand |
|
Hi @guestisp , anychance to retrigger runboat ? |
|
/ocabot rebase |
There's no commits preservation, as the module doesn't serve as is on v9.
without this fix, any regular notification (added as follower, thread notifications...) were not parsed at all and as a consequence also not debranded.
Currently translated at 40.0% (2 of 5 strings) Translation: social-12.0/social-12.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_debrand/pt/
Currently translated at 100.0% (5 of 5 strings) Translation: social-12.0/social-12.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_debrand/sl/
- FIX bug when split email message by `to_keep` parameter. When the html code is split, it is broken. As a result of this, when it use `fromstring`,
it try to fix this by closing tags.
Example about fixed functionality:
message:
`
<table>
<tr>
<td>
{to_keep}
</td>
</tr>
</table>
`
Split messsage inside `remove_href_odoo` function:
part[0]
`
<table>
<tr>
<td>
`
--------
part[1]
`
</td>
</tr>
</table>
`
-----------------
Result when join by `to_keep`
`
<table>
<tr>
<td>
{to_keep}
</td>
</tr>
</table>
`
update function calls to use new internal names, use qweb_view engine to be able to specify the template via xmlid
…of type 'NoneType' has no len()
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-16.0/social-16.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_debrand/
Currently translated at 100.0% (3 of 3 strings) Translation: social-16.0/social-16.0-mail_debrand Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_debrand/es/
|
Congratulations, PR rebased to 17.0. |
OCA-git-bot
force-pushed
the
17.0-mig-mail_debrand
branch
from
4ff9df8 to
9d7e884
Compare
|
Hi @guestisp i created guestisp#1 to pick #1272 and #1287 |
|
Hi @guestisp I also created a PR onto your PR guestisp#2 to pick up what looks like some missed localization work on the 16 branch, fix some code comments and unit test |
|
Hello, no feedback from the author of this PR. so i create this new one #1358 |
|
Whats the status here? |
|
Probably it is necessary to overseed this PR because the author is not answering |
|
Closing in favor of #1358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.