Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] mail_layout_preview: Migrate to version 15.0 #1143

Merged
merged 11 commits into from
Nov 30, 2023
Merged

[15.0][MIG] mail_layout_preview: Migrate to version 15.0 #1143

merged 11 commits into from
Nov 30, 2023

Conversation

sonhd91
Copy link

@sonhd91 sonhd91 commented May 10, 2023

Supersedes #1085
To handle cases where templates without records may raise errors during preview rendering, add condition check in the _compute_layout_preview_url function.

This was referenced May 10, 2023
Closed
Merged
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 26, 2023
@sonhd91
Copy link
Author

sonhd91 commented Nov 27, 2023

Hello @simahawk, can you take a look ?

@simahawk
Copy link
Contributor

@sonhd91 LG. Can you please cleanup the commits? The last commit seems to not contain just the fix. It would be also nice if it says

[fix] mail_layout_preview: no record to render

$short_explanation

@simahawk simahawk removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 27, 2023
@sonhd91 sonhd91 force-pushed the 15.0_mail_layout_preview branch from d93960f to f330e19 Compare November 27, 2023 10:46
@sonhd91
Copy link
Author

sonhd91 commented Nov 27, 2023

@sonhd91 LG. Can you please cleanup the commits? The last commit seems to not contain just the fix. It would be also nice if it says

[fix] mail_layout_preview: no record to render

$short_explanation

Updated

simahawk
simahawk approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Is the fix to be backported?

bizzappdev and others added 2 commits November 30, 2023 09:57
@bizzappdev
[MIG][15.0]mail_layout_preview:Migration to 15.0
5c51b21
[fix] mail_layout_preview: no record to render
133a017 
Fixing cases where the template doesn't have a record to render a preview.
@sonhd91 sonhd91 force-pushed the 15.0_mail_layout_preview branch from f330e19 to 133a017 Compare November 30, 2023 02:59
@sonhd91 sonhd91 mentioned this pull request Nov 30, 2023
Closed
@sonhd91
Copy link
Author

sonhd91 commented Nov 30, 2023 •
edited
Loading

Thanks! Is the fix to be backported?

I just did it

@simahawk
Copy link
Contributor

/ocabot merge nobump

@simahawk
Copy link
Contributor

/ocabot migration mail_layout_preview

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1143-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Nov 30, 2023
@OCA-git-bot OCA-git-bot merged commit b738c56 into OCA:15.0 Nov 30, 2023
5 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 45de0a0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sonhd91 @simahawk @OCA-git-bot @oca-travis @phuctranfxvn @bizzappdev