[18.0][MIG] server_action_mass_edit: Migration to 18.0 #951

trisdoan · 2024-10-10T02:37:20Z

Note

based on: [18.0][FIX] base_technical_features: fix incorrect replacement #980

pedrobaeza · 2024-10-10T06:27:11Z

/ocabot migration server_action_mass_edit

florenciafrigieri2 · 2024-10-16T13:44:28Z

@trisdoan Hi! I tested the module but it didn't worked.
I created a server action to change the salesperson in the SOs, but when selecting the action within sales an error came up (I was not able to even see the wizard).

This are the last lines of the error:
File "/mnt/data/odoo-addons-dir/server_action_mass_edit/wizard/mass_editing_wizard.py", line 93, in onchange
dynamic_fields["selection__" + line.field_id.name] = fields.Selection(
File "/opt/odoo/odoo/fields.py", line 2772, in init
self._selection = dict(selection) if isinstance(selection, list) else None
ValueError: dictionary update sequence element #0 has length 0; 2 is required

I leave here a print of the server action

trisdoan · 2024-10-18T08:45:55Z

@trisdoan Hi! I tested the module but it didn't worked. I created a server action to change the salesperson in the SOs, but when selecting the action within sales an error came up (I was not able to even see the wizard).

This are the last lines of the error: File "/mnt/data/odoo-addons-dir/server_action_mass_edit/wizard/mass_editing_wizard.py", line 93, in onchange dynamic_fields["selection__" + line.field_id.name] = fields.Selection( File "/opt/odoo/odoo/fields.py", line 2772, in init self._selection = dict(selection) if isinstance(selection, list) else None ValueError: dictionary update sequence element #0 has length 0; 2 is required

I leave here a print of the server action

Hi @florenciafrigieri2, thank you for the review

I just added a fix, could you please try again?

TDu

I don't see the error mentioned by @florenciafrigieri2 anymore, but I am not familiar with this module !
Code review looks good.

henrybackman

Couple of minor comments

henrybackman · 2024-10-29T14:45:46Z

server_action_mass_edit/tests/test_mass_editing.py

+
+@common.tagged("-at_install", "post_install")
+class TestMassEditing(common.TransactionCase):
+    def setUp(self):


Would setUpClass work for the common test setup to avoid running the setup separately for each test case?

henrybackman · 2024-10-29T14:51:26Z

server_action_mass_edit/tests/test_mass_editing.py

+    def test_wiz_fields_view_get(self):
+        """Test whether fields_view_get method returns arch.


Suggested change

def test_wiz_fields_view_get(self):

"""Test whether fields_view_get method returns arch.

def test_wiz_get_view(self):

"""Test whether get_view method returns arch.

henrybackman · 2024-10-29T14:52:34Z

server_action_mass_edit/wizard/mass_editing_wizard.py

+        return vals_list
+
+    def read(self, fields=None, load="_classic_read"):
+        """Without this call, dynamic fields build by fields_view_get()


Suggested change

"""Without this call, dynamic fields build by fields_view_get()

"""Without this call, dynamic fields build by get_view()

florenciafrigieri2

Functional test! Now is working ok!

OCA-git-bot · 2024-10-29T15:07:27Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

stefsava · 2024-10-29T18:25:52Z

It seems like there is a regression.
I can't bulk insert product attributes, while I could do it in 17.0.

Before it asked me to add a line,
now it doesn't ask and there are multiple columns.

With 17.0

With 18.0 and this PR

legalsylvain

See @stefsava comment.

trisdoan · 2024-11-07T03:52:00Z

Hello @stefsava, I checked and it looks to me that the issue is not because of the module

I tried with different o2m fields in another model
For product attribute, after https://github.com/odoo/odoo/pull/160270, there is a list view created and it has attribute create='false'. I changed to create='true' (for testing only), here's result:

stefsava · 2024-11-07T15:56:15Z

Hello @trisdoan

your suggestion doesn't solve my use case.

If I change create='true' I can see "Add a row", but the choice doesn't lead to anything useful.

Instead I found a workaround that brings the behavior back to that of 17.0 that I think can help you understand the problem detected.

I discovered that 17.0 only has the view "product.template.attribute.line.form" while
18.0 has added "product.template.attribute.line.view.list", and for some reason that I don't understand the list view is chosen instead of the form view.

My workaround was simply to deactive the list view, although I fear it may introduce regressions elsewhere.

trisdoan · 2024-11-29T05:15:55Z

~~DRAFT: working on failed test~~

trisdoan · 2024-12-09T05:01:56Z

Hi, I updated the code to include a pre-hook which handles the renaming (benefit those who use the addon in 14.0 and now migrate to 18.0)

PaulGoubert

Functionnal review OK

grindtildeath · 2024-12-17T15:17:24Z

Thanks for the mig.
While we are at it, can we please bring #963 in the new version? 🙏

cc @etobella @pedrobaeza @legalsylvain

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/

Currently translated at 100.0% (44 of 44 strings) Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/es_MX/

Currently translated at 100.0% (44 of 44 strings) Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/it/

…y field

…TumbaoJu

…TumbaoJu

add pre-init-hook

trisdoan · 2024-12-25T05:07:01Z

Hello @pedrobaeza, @grindtildeath , @legalsylvain , @etobella , @rousseldenis , I extracted the proposal of Akim into a new module: #985

tate11 · 2025-01-13T22:19:16Z

Hello @pedrobaeza, @grindtildeath , @legalsylvain , @etobella , @rousseldenis , I extracted the proposal of Akim into a new module: #985

I tried it locally, it doesn't work.

2025-01-13 22:11:13,708 18900 ERROR odoo_v18 odoo.sql_db: bad query: b'INSERT INTO "product_supplierinfo" ("company_id", "create_date", "create_uid", "currency_id", "date_end", "date_start", "delay", "discount", "min_qty", "price", "product_code", "product_id", "product_name", "product_tmpl_id", "sequence", "write_date", "write_uid") VALUES (2, '2025-01-13 22:11:13.699676', 2, 31, NULL, NULL, 1, '0.00', '0.00', '0.00', NULL, NULL, NULL, 281, 1, '2025-01-13 22:11:13.699676', 2) RETURNING "id"'
ERROR: null value in column "partner_id" of relation "product_supplierinfo" violates not-null constraint
DETAIL: Failing row contains (26, null, 1, 2, 31, null, 281, 1, 2, 2, null, null, null, null, 0.00, 0.00, 0.00, 2025-01-13 22:11:13.699676, 2025-01-13 22:11:13.699676).

2025-01-13 22:11:13,712 18900 WARNING odoo_v18 odoo.http: The operation cannot be completed:

Create/update: a mandatory field is not set.
Delete: another model requires the record being deleted. If possible, archive it instead.

Model: Supplier Pricelist (product.supplierinfo)
Field: Vendor (partner_id)

trisdoan · 2025-01-15T10:45:09Z

Hello @pedrobaeza, @grindtildeath , @legalsylvain , @etobella , @rousseldenis , I extracted the proposal of Akim into a new module: #985

I tried it locally, it doesn't work.

2025-01-13 22:11:13,708 18900 ERROR odoo_v18 odoo.sql_db: bad query: b'INSERT INTO "product_supplierinfo" ("company_id", "create_date", "create_uid", "currency_id", "date_end", "date_start", "delay", "discount", "min_qty", "price", "product_code", "product_id", "product_name", "product_tmpl_id", "sequence", "write_date", "write_uid") VALUES (2, '2025-01-13 22:11:13.699676', 2, 31, NULL, NULL, 1, '0.00', '0.00', '0.00', NULL, NULL, NULL, 281, 1, '2025-01-13 22:11:13.699676', 2) RETURNING "id"' ERROR: null value in column "partner_id" of relation "product_supplierinfo" violates not-null constraint DETAIL: Failing row contains (26, null, 1, 2, 31, null, 281, 1, 2, 2, null, null, null, null, 0.00, 0.00, 0.00, 2025-01-13 22:11:13.699676, 2025-01-13 22:11:13.699676).

2025-01-13 22:11:13,712 18900 WARNING odoo_v18 odoo.http: The operation cannot be completed:
* Create/update: a mandatory field is not set.

* Delete: another model requires the record being deleted. If possible, archive it instead.
Model: Supplier Pricelist (product.supplierinfo) Field: Vendor (partner_id)

Hello @tate11, it looks to me the issue is not due to the module

I got same error with version 17.0

Could you please provide steps to reproduce?

StephaneMangin · 2025-02-03T12:51:37Z

@legalsylvain A little UP on this topic to go forward.

legalsylvain · 2025-02-03T13:02:46Z

@legalsylvain A little UP on this topic to go forward.

Unfortunately, we don't find any solution for the onchange bug. So at this step, we are stuck. I don't know how to move forward.

Regards.

pedrobaeza · 2025-02-03T15:15:42Z

It's not a bug. Just have the base module and add an extra module for executing the onchanges.

StefanRijnhart

Thank you @trisdoan! Tested successfully.

@tate11 I think the issue is that the supplierinfo list view sets partner_id to readonly (https://github.com/odoo/odoo/blob/18.0/addons/product/views/product_supplierinfo_views.xml#L93). If I reset this attribute in my local database the mass editing of vendors on products works as expected. I don't think we can fix it easily here.

About the onchange situation, @trisdoan has already done the work to split it up in a separate module (in #985) so I think we can go ahead on this one and continue the discussion there.

pedrobaeza · 2025-02-05T17:01:49Z

Yes, we can continue thus:

/ocabot merge nobump

OCA-git-bot · 2025-02-05T17:02:01Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-951-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2025-02-05T17:06:12Z

Congratulations, your PR was merged at 27c4d32. Thanks a lot for contributing to OCA. ❤️

trisdoan force-pushed the 18.0-mig-server_action_mass_edit branch from 29381ab to 0f93b99 Compare October 10, 2024 02:43

OCA-git-bot added this to the 18.0 milestone Oct 10, 2024

OCA-git-bot mentioned this pull request Oct 10, 2024

Migration to version 18.0 #948

Open

19 tasks

trisdoan mentioned this pull request Oct 10, 2024

[18.0][MIG] server_action_mass_edit: Migration to 18.0 camptocamp/server-ux#2

Closed

trisdoan force-pushed the 18.0-mig-server_action_mass_edit branch from 0f93b99 to 7399b98 Compare October 18, 2024 08:45

TDu approved these changes Oct 29, 2024

View reviewed changes

henrybackman approved these changes Oct 29, 2024

View reviewed changes

OCA-git-bot added the approved label Oct 29, 2024

florenciafrigieri2 approved these changes Oct 29, 2024

View reviewed changes

OCA-git-bot added the ready to merge label Oct 29, 2024

legalsylvain requested changes Oct 30, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Oct 30, 2024

trisdoan force-pushed the 18.0-mig-server_action_mass_edit branch 3 times, most recently from 87e31a4 to 6b8dca7 Compare November 29, 2024 05:11

trisdoan marked this pull request as draft November 29, 2024 05:15

trisdoan force-pushed the 18.0-mig-server_action_mass_edit branch from 6b8dca7 to f88d10f Compare December 9, 2024 04:58

trisdoan marked this pull request as ready for review December 9, 2024 04:58

PaulGoubert approved these changes Dec 17, 2024

View reviewed changes

CRogos and others added 13 commits December 24, 2024 10:30

[IMP] server_action_mass_edit: black, isort, prettier

00a014b

[MIG] server_action_mass_edit: Migration to 17.0

ef9a9b7

[UPD] Update server_action_mass_edit.pot

93b5209

[BOT] post-merge updates

9f46740

Update translation files

07ec11f

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/

Translated using Weblate (Spanish (Mexico))

b00e431

Currently translated at 100.0% (44 of 44 strings) Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/es_MX/

Translated using Weblate (Italian)

ec8de6d

Currently translated at 100.0% (44 of 44 strings) Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/it/

[FIX] server_action_mess_edit: Application error when discard a x2man…

bcf49c0

…y field

[BOT] post-merge updates

e810fa1

[IMP] Improve documentation during OCA Days 2024 Workshop thanks to @…

e979640

…TumbaoJu

[BOT] post-merge updates

15d51bd

[IMP] server_action_mass_edit: pre-commit auto fixes

6c91a90

[MIG] server_action_mass_edit: Migration to 18.0

c22320c

add pre-init-hook

trisdoan force-pushed the 18.0-mig-server_action_mass_edit branch 2 times, most recently from b9d666f to c22320c Compare December 24, 2024 05:47

trisdoan mentioned this pull request Dec 25, 2024

[18.0][ADD] server_action_mass_edit_onchange: extension to support playing onchange #985

Open

StefanRijnhart approved these changes Feb 5, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Feb 5, 2025

OCA-git-bot merged commit 76753de into OCA:18.0 Feb 5, 2025
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] server_action_mass_edit: Migration to 18.0 #951

[18.0][MIG] server_action_mass_edit: Migration to 18.0 #951

trisdoan commented Oct 10, 2024 •

edited

Loading

pedrobaeza commented Oct 10, 2024

florenciafrigieri2 commented Oct 16, 2024

trisdoan commented Oct 18, 2024

TDu left a comment

henrybackman left a comment

henrybackman Oct 29, 2024

henrybackman Oct 29, 2024

henrybackman Oct 29, 2024

florenciafrigieri2 left a comment

OCA-git-bot commented Oct 29, 2024

stefsava commented Oct 29, 2024

legalsylvain left a comment

trisdoan commented Nov 7, 2024 •

edited

Loading

stefsava commented Nov 7, 2024

trisdoan commented Nov 29, 2024 •

edited

Loading

trisdoan commented Dec 9, 2024 •

edited

Loading

PaulGoubert left a comment

grindtildeath commented Dec 17, 2024

trisdoan commented Dec 25, 2024 •

edited

Loading

tate11 commented Jan 13, 2025

trisdoan commented Jan 15, 2025

StephaneMangin commented Feb 3, 2025

legalsylvain commented Feb 3, 2025

pedrobaeza commented Feb 3, 2025

StefanRijnhart left a comment

pedrobaeza commented Feb 5, 2025

OCA-git-bot commented Feb 5, 2025

OCA-git-bot commented Feb 5, 2025

		def test_wiz_fields_view_get(self):
		"""Test whether fields_view_get method returns arch.

	"""Without this call, dynamic fields build by fields_view_get()
	"""Without this call, dynamic fields build by get_view()

[18.0][MIG] server_action_mass_edit: Migration to 18.0 #951

[18.0][MIG] server_action_mass_edit: Migration to 18.0 #951

Conversation

trisdoan commented Oct 10, 2024 • edited Loading

Note

pedrobaeza commented Oct 10, 2024

florenciafrigieri2 commented Oct 16, 2024

trisdoan commented Oct 18, 2024

TDu left a comment

Choose a reason for hiding this comment

henrybackman left a comment

Choose a reason for hiding this comment

henrybackman Oct 29, 2024

Choose a reason for hiding this comment

henrybackman Oct 29, 2024

Choose a reason for hiding this comment

henrybackman Oct 29, 2024

Choose a reason for hiding this comment

florenciafrigieri2 left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Oct 29, 2024

stefsava commented Oct 29, 2024

legalsylvain left a comment

Choose a reason for hiding this comment

trisdoan commented Nov 7, 2024 • edited Loading

stefsava commented Nov 7, 2024

trisdoan commented Nov 29, 2024 • edited Loading

trisdoan commented Dec 9, 2024 • edited Loading

PaulGoubert left a comment

Choose a reason for hiding this comment

grindtildeath commented Dec 17, 2024

trisdoan commented Dec 25, 2024 • edited Loading

tate11 commented Jan 13, 2025

trisdoan commented Jan 15, 2025

StephaneMangin commented Feb 3, 2025

legalsylvain commented Feb 3, 2025

pedrobaeza commented Feb 3, 2025

StefanRijnhart left a comment

Choose a reason for hiding this comment

pedrobaeza commented Feb 5, 2025

OCA-git-bot commented Feb 5, 2025

OCA-git-bot commented Feb 5, 2025

trisdoan commented Oct 10, 2024 •

edited

Loading

trisdoan commented Nov 7, 2024 •

edited

Loading

trisdoan commented Nov 29, 2024 •

edited

Loading

trisdoan commented Dec 9, 2024 •

edited

Loading

trisdoan commented Dec 25, 2024 •

edited

Loading