-
-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][IMP] product_set: add packaging for product.set.line #1828
base: 18.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code seems better in this base module than in the sales one. 👍
You forgot to move the views.
Skip the update of auto generated files as this is an IMP
@@ -9,3 +9,4 @@ | |||
- [Tecnativa](https://www.tecnativa.com): | |||
- Pilar Vargas | |||
- Nils Coenen \<<[email protected]>\> | |||
- Tris Doan \<<[email protected]>\> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep contributors of moved code
- Tris Doan \<<tridm@trobz.com>\> | |
- Akim Juillerat \<<akim.juillerat@camptocamp.com>\> | |
- Son (Ho Dac) \<<[email protected]>\> | |
- Tris Doan \<<[email protected]>\> |
689e549
to
489ff0a
Compare
<li>Akim Juillerat <<a class="reference external" href="mailto:akim.juillerat@camptocamp.com">akim.juillerat@camptocamp.com</a>></li> | ||
<li>Son (Ho Dac) <<a class="reference external" href="mailto:hodacson.6491@gmail.com">hodacson.6491@gmail.com</a>></li> | ||
<li>Tris Doan <<a class="reference external" href="mailto:tridm@trobz.com">tridm@trobz.com</a>></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop changes to this file for IMP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, code's updated
489ff0a
to
0905290
Compare
This changes
Sale
, one example is: [18.0][MIG] sale_product_set_packaging_qty: Migration to 18.0 sale-workflow#3474