Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][IMP] product_set: add packaging for product.set.line #1828

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

trisdoan
Copy link
Contributor

@trisdoan trisdoan commented Dec 31, 2024

This changes

Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code seems better in this base module than in the sales one. 👍

You forgot to move the views.
Skip the update of auto generated files as this is an IMP

@@ -9,3 +9,4 @@
- [Tecnativa](https://www.tecnativa.com):
- Pilar Vargas
- Nils Coenen \<<[email protected]>\>
- Tris Doan \<<[email protected]>\>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep contributors of moved code

Suggested change
- Tris Doan \<<tridm@trobz.com>\>
- Akim Juillerat \<<akim.juillerat@camptocamp.com>\>
- Son (Ho Dac) \<<[email protected]>\>
- Tris Doan \<<[email protected]>\>

@trisdoan trisdoan force-pushed the 18.0-product-set-add-packaging branch 2 times, most recently from 689e549 to 489ff0a Compare December 31, 2024 10:35
@trisdoan trisdoan requested a review from jbaudoux December 31, 2024 10:36
Comment on lines 431 to 433
<li>Akim Juillerat &lt;<a class="reference external" href="mailto:akim.juillerat&#64;camptocamp.com">akim.juillerat&#64;camptocamp.com</a>&gt;</li>
<li>Son (Ho Dac) &lt;<a class="reference external" href="mailto:hodacson.6491&#64;gmail.com">hodacson.6491&#64;gmail.com</a>&gt;</li>
<li>Tris Doan &lt;<a class="reference external" href="mailto:tridm&#64;trobz.com">tridm&#64;trobz.com</a>&gt;</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop changes to this file for IMP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, code's updated

@trisdoan trisdoan force-pushed the 18.0-product-set-add-packaging branch from 489ff0a to 0905290 Compare January 2, 2025 01:57
@trisdoan trisdoan requested a review from jbaudoux January 2, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants