Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] product_supplierinfo_archive: Migration to 18.0 #1771 #1772

Closed
wants to merge 19 commits into from

Conversation

pfranck
Copy link

@pfranck pfranck commented Nov 13, 2024

No description provided.

@pfranck pfranck mentioned this pull request Nov 13, 2024
30 tasks
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You somehow squashed your migration commit into the pre-commit one

@pfranck
Copy link
Author

pfranck commented Nov 25, 2024

Actually there was no fix -- the module work out of the box - that why we have only 1 commit.
unless you want me to create a new commit to change the version of the module

@pedrobaeza
Copy link
Member

@sebalix I included the other this clarification on the migration commit because of the lack of pre-commit auto-fixes:

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0/_compare/3d012e10cc5c6f542cc1a47a4820a5cebb881cd2...a96cf3dc2c6e60f4b14eb45305cd1ed08501d77b

@pfranck
Copy link
Author

pfranck commented Nov 25, 2024

So you don't expect people to bump the version 18.0 before running git commit -m "[IMP] $module: pre-commit auto fixes"

<field name="inherit_id" ref="product.product_supplierinfo_tree_view" />
<field name="arch" type="xml">
<field name="price" position="after">
<field name="active" invisible="1" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing fields used in domains and other attributes are added to the view as invisible automatically. If you encounter fields in views with invisible="True", they can probably be removed. Reference: odoo/odoo#137031

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks weird

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pfranck can you address this comment please? 🙏

@rousseldenis
Copy link
Contributor

So you don't expect people to bump the version 18.0 before running git commit -m "[IMP] $module: pre-commit auto fixes"

Nope, that's the flow. The pre-commit fixes should be applied with the configuration of the destination branch and commited with --no-verify configuration.

Then, the migration changes should be applied

@Kimkhoi3010
Copy link

Hi @pfranck, @pedrobaeza, @rousseldenis, @sebalix, I created #1825 to take over this PR.

@pedrobaeza
Copy link
Member

Superseded by #1825

@pedrobaeza pedrobaeza closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.