Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] product_internal_reference_generator: create sequence as sudo #1481

Merged
merged 1 commit into from
Dec 18, 2023
Merged

[14.0][FIX] product_internal_reference_generator: create sequence as sudo #1481

merged 1 commit into from
Dec 18, 2023

Conversation

ilyasProgrammer
Copy link
Member

@ilyasProgrammer ilyasProgrammer commented Dec 13, 2023 •
edited
Loading

  • do not copy prefix and int. ref
  • btn_generate_sequence - for specail group: Generate internal reference
  • generate sequence as sudo
    and more

@ilyasProgrammer ilyasProgrammer force-pushed the 14.0-product_internal_reference_generator-copy-false branch 7 times, most recently from 57b7366 to 3888a47 Compare December 18, 2023 09:14
aleuffre
aleuffre approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@ilyasProgrammer ilyasProgrammer force-pushed the 14.0-product_internal_reference_generator-copy-false branch from ab92ea1 to e1805c3 Compare December 18, 2023 12:18
@ilyasProgrammer ilyasProgrammer force-pushed the 14.0-product_internal_reference_generator-copy-false branch from e1805c3 to fe5a895 Compare December 18, 2023 12:19
renda-dev
renda-dev approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@renda-dev renda-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ilyasProgrammer
Copy link
Member Author

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1481-by-ilyasProgrammer-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b208674 into OCA:14.0 Dec 18, 2023
8 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 32d8b5a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleuffre aleuffre aleuffre approved these changes

@renda-dev renda-dev renda-dev approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilyasProgrammer @OCA-git-bot @renda-dev @aleuffre