Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] product_print_category fix a security issue #1480

Merged

Conversation

nayatec
Copy link
Contributor

@nayatec nayatec commented Dec 12, 2023

Odoo V16 does not allow 'regular' users (ie users with no Admin/Access Right group) to acces to ir.model.fields at all, therefore i added a sudo to allow users with no such right to be able to actually write to products.
Did not find a more elegant solution.

@OCA-git-bot
Copy link
Contributor

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat / 16.0 with demo user.
indeed we have an error. (this should be new in V16, I didn't have any problem in V12).

image

LGTM. Thanks for fixing this issue.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1480-by-legalsylvain-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6204a7f into OCA:16.0 Dec 12, 2023
8 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d09bb0f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants