Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] product_code_regex_validation #1430

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[16.0][ADD] product_code_regex_validation #1430

merged 1 commit into from
Sep 3, 2024

Conversation

JordiMForgeFlow
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow commented Oct 10, 2023 •
edited
Loading

Module to add regex validation of product codes based on a expression defined at product category level

@JordiMForgeFlow JordiMForgeFlow force-pushed the 16.0-add-product_code_regex_validation branch from 95b639b to 94ddc8a Compare October 10, 2023 11:45
AaronHForgeFlow
AaronHForgeFlow approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good!

@JordiMForgeFlow JordiMForgeFlow force-pushed the 16.0-add-product_code_regex_validation branch from 94ddc8a to e6ee1cd Compare October 31, 2023 15:51
@JordiMForgeFlow JordiMForgeFlow force-pushed the 16.0-add-product_code_regex_validation branch from e6ee1cd to cdd51fa Compare December 10, 2023 14:58
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 14, 2024
LoisRForgeFlow
LoisRForgeFlow approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

MiquelRForgeFlow
MiquelRForgeFlow approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ChrisOForgeFlow
ChrisOForgeFlow approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@ChrisOForgeFlow ChrisOForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great!

@JordiMForgeFlow
Copy link
Contributor Author

@OCA/product-maintainers could we get this one merged? :)

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 21, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 25, 2024
@JordiBForgeFlow
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1430-by-JordiBForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 856978d into OCA:16.0 Sep 3, 2024
6 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ade7ab2. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 16.0-add-product_code_regex_validation branch September 3, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisOForgeFlow ChrisOForgeFlow ChrisOForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JordiMForgeFlow @JordiBForgeFlow @OCA-git-bot @AaronHForgeFlow @LoisRForgeFlow @MiquelRForgeFlow @ChrisOForgeFlow