Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][REF] l10n_br_cnpj_search, l10n_br_crm_cnpj_search: Allow API search even with partner_id filled #3597

Draft
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

corredato
Copy link
Contributor

Essa PR permite que o default_get do cnpj_search seja herdável e não retorne um erro caso a busca por cnpj possua um partner_id preenchido no lead.

@OCA-git-bot
Copy link
Contributor

Hi @mileo,
some modules you are maintaining are being modified, check this out!

@corredato corredato force-pushed the 16.0-ref-cnpj_search branch from 37a1528 to dde3121 Compare January 24, 2025 20:47
@corredato corredato force-pushed the 16.0-ref-cnpj_search branch from dde3121 to 3d401b1 Compare January 24, 2025 22:08
rvalyi
rvalyi previously approved these changes Jan 28, 2025
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvalyi
Copy link
Member

rvalyi commented Jan 28, 2025

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3597-by-rvalyi-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 28, 2025
Signed-off-by rvalyi
@OCA-git-bot
Copy link
Contributor

@rvalyi your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-3597-by-rvalyi-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@antoniospneto
Copy link
Contributor

Ops, os testes estão falhando

@rvalyi rvalyi dismissed their stale review January 29, 2025 13:41

testes falhando

@rvalyi rvalyi marked this pull request as draft February 17, 2025 20:51
@mbcosta
Copy link
Contributor

mbcosta commented Feb 19, 2025

@corredato você precisa resolver os erros que o seu PR estão causando para que seja possível ser Integrado/Merge, por algum motivo inicialmente os Testes rodaram sem erro porém no momento de Integrar/Merge o PR os testes rodam novamente e acabaram retornando erros, o que impede o seu PR de ser Integrado, você pode rodar os Testes dos módulos que você está alterando localmente para ver o erro mas antes de subir o PR o recomendado é rodar os testes simulando a mesma forma que o CI faz

  • Initialize test db

https://github.com/OCA/l10n-brazil/actions/runs/12958414158/job/36148773304?pr=3597#step:8:14

$ createdb odoo
$ odoo -d odoo -i account,account_due_list,account_due_list_payment_mode,account_move_base_import,account_payment_order,account_payment_partner,account_usability,base,base_address_extended,base_setup,base_technical_features,contacts,crm,currency_rate_update,hr,hr_employee_relative,mis_builder,product,purchase,resource,sale_management,stock,stock_account,stock_picking_invoicing,web_responsive,web_theme_classic --stop-after-init
odoo -d odoo -i l10n_br_account,l10n_br_account_due_list,l10n_br_account_nfe,l10n_br_account_payment_brcobranca,l10n_br_account_payment_order,l10n_br_base,l10n_br_cnab_structure,l10n_br_cnpj_search,l10n_br_coa,l10n_br_coa_generic,l10n_br_coa_simple,l10n_br_crm,l10n_br_crm_cnpj_search,l10n_br_currency_rate_update,l10n_br_fiscal,l10n_br_fiscal_certificate,l10n_br_fiscal_closing,l10n_br_fiscal_dfe,l10n_br_fiscal_edi,l10n_br_hr,l10n_br_ie_search,l10n_br_mis_report,l10n_br_nfe,l10n_br_nfe_spec,l10n_br_nfse,l10n_br_nfse_focus,l10n_br_purchase,l10n_br_purchase_stock,l10n_br_resource,l10n_br_sale,l10n_br_setup_tests,l10n_br_stock,l10n_br_stock_account,l10n_br_zip,spec_driven_model --test-enable --stop-after-init

É importante verificar se os erros que acontecem tem relação com a sua alteração, pode acontecer erros não relacionados, mas nesse caso parece que sim

https://github.com/OCA/l10n-brazil/actions/runs/12958414158/job/36148773304?pr=3597#step:9:1495

image

https://github.com/OCA/l10n-brazil/actions/runs/12958414158/job/36148773304?pr=3597#step:9:2218

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants