Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] l10n_br_sale: Possibilidade de incluir uma Seção ou Nota na Linha do Pedido de Vendas #2866

Merged

Conversation

mbcosta
Copy link
Contributor

@mbcosta mbcosta commented Jan 16, 2024

The possibility of include a Section or Note in Sale lines when Sale Order has Fiscal Operation.

PR simples que resolve o issue #2863 que é a possibilidade de incluir uma Seção ou Nota na Linha do Pedido de Vendas no caso que tem Operação Fiscal ou caso internacional

image

image

image

image

Para resolver coloquei no atributo de Requerido da Linha de Operação Fiscal o fiscal_operation e o product_id quando não forem Falso

image

image

image

cc @renatonlima @rvalyi @marcelsavegnago @mileo @douglascstd @antoniospneto

@OCA-git-bot
Copy link
Contributor

Hi @renatonlima,
some modules you are maintaining are being modified, check this out!

Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

certeza se não deveria ser parent.fiscal_operation_id ? tou achando estranho ser apenas fiscal_operation_id pro required e parent.fiscal_operation_id pro invisible. Ta certo mesmo?

…ale lines when Sale Order has Fiscal Operation.
@mbcosta mbcosta force-pushed the 14.0-FIX-include_section_or_note_in_sale_line branch from 05deceb to a8f36c6 Compare January 16, 2024 19:05
@mbcosta
Copy link
Contributor Author

mbcosta commented Jan 16, 2024

Valeu @rvalyi alteração feita

@rvalyi
Copy link
Member

rvalyi commented Jan 18, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-2866-by-rvalyi-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0178e92 into OCA:14.0 Jan 19, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4315f49. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants