Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] l10n_br_sale_commission_stock #2681

Closed

Conversation

DiegoParadeda
Copy link
Contributor

No description provided.

@DiegoParadeda DiegoParadeda marked this pull request as ready for review September 14, 2023 19:16
@mbcosta
Copy link
Contributor

mbcosta commented May 13, 2024

Valeu @DiegoParadeda , apenas para registro no PR #2955 está sendo feita a extração de partes do modulo l10n_br_sale_stock para o repositório account-invoicing onde foram feitas melhorias nessa implementação para evitar a necessidade de "glue modules" como esse modulo, como a solução proposta parece atender os N casos onde algum modulo acaba incluindo novos campos nos métodos que criam uma Fatura a partir de Vendas e com isso evita a necessidade de ter tanto esse modulo quanto os outros N para cada novo caso, acredito que o melhor será buscar fazer a revisão dessa extração, eu fiz o teste com o caso Comissão e parece funcionar sem erros, agradeço ser puder fazer a revisão

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 15, 2024
@antoniospneto antoniospneto changed the title 14.0 mig l10n br sale commission stock [14.0][MIG] l10n_br_sale_commission_stock Oct 4, 2024
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 6, 2024
@mbcosta
Copy link
Contributor

mbcosta commented Jan 15, 2025

@OCA/local-brazil-maintainers com o Merge do PR #2955 acredito que esse módulo se tornou desnecessário e o PR pode ser fechado

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants