Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] fieldservice_repair: Allow changing type properly #1291

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

jcoux
Copy link

@jcoux jcoux commented Dec 13, 2024

With the current implementation of the module, the repair order is only created at the creation of the fsm order.

That PR adds type changing management.

  • When removing the repair type:

    • cancel the repair order
    • remove the link between the repair order and the fsm order
  • When adding the repair type:

    • create the repair order

@OCA-git-bot
Copy link
Contributor

Hi @smangukiya, @max3903,
some modules you are maintaining are being modified, check this out!

With the current implementation of the module,
the repair order is only created at the creation of the fsm order.

That PR adds type changing management.

* When removing the repair type:
  * cancel the repair order
  * remove the link between the repair order and the fsm order

* When adding the repair type:
  * create the repair order
@jcoux jcoux force-pushed the 17.0_fix_fieldservice_repair_changing_type branch from 05aa087 to 208e223 Compare December 13, 2024 10:30
@max3903 max3903 added this to the 17.0 milestone Dec 15, 2024
@max3903 max3903 self-assigned this Dec 15, 2024
@jcoux jcoux marked this pull request as ready for review December 16, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants