[17.0][FIX] account_invoice_section_sale_order: FWD port and fix test-case #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguel-S73
approved these changes
Jan 8, 2025
1 task
|
@sergiocorato @simahawk Could any of you kindly review this PR? Thank you! |
|
@TDu Can you take a look at this fix please? |
There was a problem hiding this comment.
Thanks for fixing the tests! I see they were caused by Odoo adding taxes to demo products in odoo/odoo@1443e5503c7396512a. Hope we can merge this one fast. Just a small question.
the `sale.order._create_invoices() method does not only requires `create` access to the `account.move` and `account.move.line` models. Because we're actually sorting lines after the creating, it requires `read` access to sort, and `write` access to modify their sequence. This is problematic when interracting with other modules like `invoice_mode_at_shipping` where stock users are the ones to create invoices. This commit adds a few `sudo()` in the code, in order to avoid granting `read` and `write` access to users that shouldn't be allowed to read and write invoices.
…nvoice_with_currency
LucasTran380381
force-pushed
the
17.0-fix-account_invoice_section_sale_order
branch
from
17292ca to
c62dfd9
Compare
|
@StefanRijnhart fine for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FWD ports
#1774
#1862
#1770
Fix test-case
test_create_invoice_with_currencychange compare