-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][15.0] account_invoicing_mode_at_shipping (renamed) #1247
[MIG][15.0] account_invoicing_mode_at_shipping (renamed) #1247
Conversation
Add three modules helping on automatically invoicing customers. The base module `account_invoice_base_invoicing_mode` does not actually do anything but adds a selection field on partner to allow assigning an invoicing mode to a customer. And a checkbox to choose regrouping invoices. The two other modules add specific invoicing mode. The module `account_invoice_mode_monthly` creates monthly invoices for customer on a specific day (configuration is in Accounting Settings) The module `account_invoice_mode_at_shipping` creates invoices on the shipping of the goods. Those modules use queue_job to generate and validate invoices.
If we group several sales in the same procurement group, we'll invoice only one sale order. Tracing back to the sales through the stock moves ensure we invoice all of them.
Through the stock moves
Add few changes from reviews. Use sudo to post the invoice.
Split invoice creation on invoice partner settings that decides if sales order atre being grouped in invoice or not. The previous implementation would crash.
Filter out sales order that have nothing to invoice. To avoid an exception at invoice createion.
Add explicit message if nothing is invoiced
cee952a
to
46c45e7
Compare
@TDu To easy review, could you add the dependency PR link in this description ? Thanks |
d2482b4
to
133b68f
Compare
/ocabot migration account_invoice_mode_at_shipping |
Can you remove the migration script here as well? |
133b68f
to
f328831
Compare
@StefanRijnhart Done |
f328831
to
53e6d1f
Compare
@pedrobaeza this one can either be merge :) thanks ! |
It can't be merged without removing the unreleased dependency |
@pedrobaeza the dependency is on the account_invoice_base_invoicing_mode which has been merged yesterday. |
@houssine78 |
53e6d1f
to
6186fe8
Compare
@StefanRijnhart I removed the |
Thanks! |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 563cd20. Thanks a lot for contributing to OCA. ❤️ |
This module migration depends on #1243
It also takes over this pr #1101