Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][15.0] account_invoicing_mode_at_shipping (renamed) #1247

Merged
merged 21 commits into from
Apr 20, 2023

Conversation

TDu
Copy link
Member

@TDu TDu commented Sep 27, 2022

This module migration depends on #1243

It also takes over this pr #1101

TDu and others added 19 commits September 27, 2022 15:05
Add three modules helping on automatically invoicing customers.

The base module `account_invoice_base_invoicing_mode` does not actually
do anything but adds a selection field on partner to allow assigning an
invoicing mode to a customer. And a checkbox to choose regrouping
invoices.

The two other modules add specific invoicing mode.

The module `account_invoice_mode_monthly` creates monthly invoices for
customer on a specific day (configuration is in Accounting Settings)

The module `account_invoice_mode_at_shipping` creates invoices on the
shipping of the goods.

Those modules use queue_job to generate and validate invoices.
If we group several sales in the same procurement group, we'll invoice
only one sale order. Tracing back to the sales through the stock moves
ensure we invoice all of them.
Add few changes from reviews.
Use sudo to post the invoice.
Split invoice creation on invoice partner settings that decides if sales order
atre being grouped in invoice or not.
The previous implementation would crash.
Filter out sales order that have nothing to invoice.
To avoid an exception at invoice createion.
Add explicit message if nothing is invoiced
@TDu TDu changed the title [MIG][15.0 [MIG][15.0] account_invoicing_mode_at_shipping (renamed) Sep 27, 2022
@TDu TDu force-pushed the 15-mig-invoice-mode-at-shipping branch from cee952a to 46c45e7 Compare September 27, 2022 13:21
@rousseldenis
Copy link
Contributor

@TDu To easy review, could you add the dependency PR link in this description ? Thanks

@rafaelbn
Copy link
Member

rafaelbn commented Dec 9, 2022

/ocabot migration account_invoice_mode_at_shipping

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Dec 9, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 9, 2022
56 tasks
@StefanRijnhart
Copy link
Member

Can you remove the migration script here as well?

@TDu TDu force-pushed the 15-mig-invoice-mode-at-shipping branch from 133b68f to f328831 Compare December 12, 2022 10:12
@TDu
Copy link
Member Author

TDu commented Dec 12, 2022

@StefanRijnhart Done

@TDu TDu force-pushed the 15-mig-invoice-mode-at-shipping branch from f328831 to 53e6d1f Compare December 13, 2022 07:04
@houssine78
Copy link

@pedrobaeza this one can either be merge :) thanks !

@pedrobaeza
Copy link
Member

It can't be merged without removing the unreleased dependency

@houssine78
Copy link

@pedrobaeza the dependency is on the account_invoice_base_invoicing_mode which has been merged yesterday.

@StefanRijnhart
Copy link
Member

StefanRijnhart commented Apr 19, 2023

@houssine78 test-requirements.txt needs to be removed by the author @TDu.

@TDu TDu force-pushed the 15-mig-invoice-mode-at-shipping branch from 53e6d1f to 6186fe8 Compare April 20, 2023 08:11
@TDu
Copy link
Member Author

TDu commented Apr 20, 2023

@StefanRijnhart I removed the test-requirements.txt change, should be good to merge.

@StefanRijnhart
Copy link
Member

Thanks!
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1247-by-StefanRijnhart-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 13a4be4 into OCA:15.0 Apr 20, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 563cd20. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.