Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] l10n_eu_oss_oca: Set tax country_id as company's fiscal country #402

Merged
merged 1 commit into from
Dec 22, 2023
Merged

[16.0][FIX] l10n_eu_oss_oca: Set tax country_id as company's fiscal country #402

merged 1 commit into from
Dec 22, 2023

Conversation

aritzolea
Copy link

No description provided.

@pedrobaeza pedrobaeza added this to the 16.0 milestone Dec 22, 2023
@pedrobaeza
Copy link
Member

The previous PR wasn't rollbacked, so you only need to change the field.

@aritzolea
Copy link
Author

But if someone updated to 16.0.1.0.1, a new 16.0.1.0.2 version script is needed so that existing taxes are updated on the database right?

@pedrobaeza
Copy link
Member

Just modify previous migration script instead of creating a new one. The possibilities of being different are few, and also the possibilities of people updating in this lapse, so let's reduce the noise.

@aritzolea aritzolea force-pushed the 16.0-fix-l10n_eu_oss_oca-country_value_fiscal branch from dd20ac0 to e03be15 Compare December 22, 2023 08:43
pedrobaeza
pedrobaeza reviewed Dec 22, 2023
View reviewed changes
l10n_eu_oss_oca/README.rst Outdated
@@ -7,7 +7,7 @@ L10n EU OSS OCA
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:fde85cb88c420131b91b360fbb84f553d4977cbbfc80cc868c52291833e08e03
!! source digest: sha256:9f24da0b57196401086a0a54b7bb7e24024c260cc4c90d42308810512634a55c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change and the one in the index.html?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were residual changes from the first pre-commit when I added a new migration script

@aritzolea aritzolea force-pushed the 16.0-fix-l10n_eu_oss_oca-country_value_fiscal branch from e03be15 to 1eafa04 Compare December 22, 2023 08:58
pedrobaeza
pedrobaeza approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-402-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9f8bde6 into OCA:16.0 Dec 22, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 08a2f9d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aritzolea @pedrobaeza @OCA-git-bot