Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Features and linting #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

skeptrunedev
Copy link

@skeptrunedev skeptrunedev commented Feb 8, 2023

I did more than @Nutlope explicitly asked for in #1, but none of these are breaking changes and I think that they all add value.

However, if there are objections to any of them, please request changes and I will edit the PR. Thanks!

  • Makes API request on paste
  • Makes API request on enter
  • Errors in all appropriate places
  • Stops loading on error
  • Put generateSummary into a callback: just a performance optimization and best practice
  • Add linting: knowing that beginners will hopefully fork this repo or use it as reference, I think it's very important to add linting. There were warnings in the dependencies arrays in the [...slug].tsx file that linting picked up in the current version of main.
  • Add prettier: The prettier-plugin-tailwindcss was already installed. However, without including it in a config file, some VIM and VSCode configurations won't pick it up. Imo, having it explicitly referenced in the config is best practice.
summarizer-features.mp4

@vercel
Copy link

vercel bot commented Feb 8, 2023

@kmkhami is attempting to deploy a commit to the Hassanteam Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant