Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify position instead of player #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

specify position instead of player #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions src/main/java/nukkitcoders/mobplugin/MobPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,19 @@ public boolean onCommand(CommandSender sender, Command cmd, String label, String
switch (args[0].toLowerCase()) {
case "spawn":
if (args.length == 1 || (args.length == 2 && !(sender instanceof Player))) {
sender.sendMessage("Usage: /mob spawn <entity> <opt:player>");
sender.sendMessage("Usage: /mob spawn <entity> <opt:player> or <pos:x,y,z>");
break;
}

String mob = args[1];
Player playerThatSpawns;
boolean toPos = false;

if (args.length == 3) {
if (args.length == 3 && args[2].contains(",")) {
toPos = true;
}

if (args.length == 3 && toPos == false) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why toPos == false instead of !toPos ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just readability, but am happy to change it.

playerThatSpawns = this.getServer().getPlayer(args[2]);
} else {
playerThatSpawns = (Player) sender;
Expand All @@ -138,10 +143,30 @@ public boolean onCommand(CommandSender sender, Command cmd, String label, String
if (playerThatSpawns != null) {
Position pos = playerThatSpawns.getPosition();

if (toPos == true) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just if (toPos) {?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just readability, but am happy to change it.

// specifying a position instead of a player
String[] arg = args[2].split(",");
playerThatSpawns = (Player) sender;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will give a ClassCastException if run from console

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will look into this, still pretty new to java.


Position newpos = new Position
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should catch the exception which comes if player gives invalid coordinates?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will look into this, at this point I do not know how to validate coordinates.

(
Double.parseDouble(arg[0]), // x
Double.parseDouble(arg[1]), // y
Double.parseDouble(arg[2]), // z
playerThatSpawns.getPosition().level
);

pos = newpos;
}

Entity ent;
if ((ent = Entity.createEntity(mob, pos)) != null) {
ent.spawnToAll();
sender.sendMessage("Spawned " + mob + " to " + playerThatSpawns.getName());
if (toPos == true) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just if (toPos) {?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just readability, but am happy to change it.

sender.sendMessage("Spawned " + mob + " to " + args[2]);
} else {
sender.sendMessage("Spawned " + mob + " to " + playerThatSpawns.getName());
}
} else {
sender.sendMessage("Unable to spawn " + mob);
}
Expand Down