New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MarkdownPreview to use Daytona. #6190

Merged

jgonz120 merged 22 commits into dev from dev-jgonz120-UpdateMarkdownPreviewVersion

Jan 4, 2025

+201 −102

Contributor

jgonz120 commented Dec 12, 2024 •

edited

Loading

Bug

Fixes: https://github.com/NuGet/Client.Engineering/issues/3109
Fixes: https://github.com/NuGet/Client.Engineering/issues/3104

Description

Update the Microsoft.VisualStudio.Markdown.Platform package to version 17.13.161. Set editor options in the PreviewBuilder to so MarkdownPreview renders content in Daytona.

PR Checklist

Meaningful title, helpful description and a linked NuGet/Home issue
~~Added tests~~
~~Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.~~

jgonz120 requested a review from a team as a code owner

December 12, 2024 18:21

jgonz120 requested review from nkolev92, zivkan, jeffkl and Nigusu-Allehu

December 12, 2024 18:23

jgonz120 commented

View reviewed changes

NuGet.Config Show resolved Hide resolved

jeffkl previously approved these changes

View reviewed changes

Contributor

jeffkl left a comment

Can't wait to see it in action!

jgonz120 dismissed jeffkl’s stale review via

00e9ff4

December 16, 2024 18:36

Nigusu-Allehu previously approved these changes

View reviewed changes

jgonz120 requested a review from jeffkl

December 16, 2024 20:02

donnie-msft reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

jgonz120 requested a review from donnie-msft

December 17, 2024 00:32

zivkan reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

jgonz120 dismissed Nigusu-Allehu’s stale review via

4f2531a

December 17, 2024 22:26

davkean reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

davkean reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

davkean reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

davkean reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

davkean reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

davkean reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

davkean reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Show resolved Hide resolved

nkolev92 mentioned this pull request

Cleanup ServiceProviderExtensions, remove GetFreeThreadedServiceAsync NuGet/Home#14007

Open

jgonz120 requested review from davkean and zivkan

December 18, 2024 21:00

davkean reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

davkean reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

davkean reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

davkean reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

davkean reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

davkean reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageManagerControl.xaml.cs Outdated Show resolved Hide resolved


          use intializeAsync cancellation token

dd00ee2

jgonz120 force-pushed the dev-jgonz120-UpdateMarkdownPreviewVersion branch from 20fcd6d to dd00ee2 Compare

December 19, 2024 22:34

jgonz120 requested a review from davkean

December 20, 2024 06:25

davkean reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageManagerControl.xaml.cs Show resolved Hide resolved

zivkan reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageManagerControl.xaml.cs Outdated Show resolved Hide resolved

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

src/NuGet.Clients/NuGet.Tools/NuGetPackage.cs Outdated Show resolved Hide resolved

...Get.VisualStudio.OnlineEnvironment.Client/SolutionExplorer/PackageManagerUICommandHandler.cs Outdated Show resolved Hide resolved

test/NuGet.Clients.Tests/NuGet.PackageManagement.UI.Test/NuGet.PackageManagement.UI.Test.csproj Outdated Show resolved Hide resolved

jgonz120 added 2 commits

January 2, 2025 15:42


          PR comment

4b4b213


          created extension method

be1de4e

zivkan previously approved these changes

View reviewed changes

Member

zivkan left a comment •

edited

Loading

just nitpicks

edit: forgot the first one was not a nitpick

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

src/NuGet.Clients/NuGet.VisualStudio.Common/GlobalSuppressions.cs Outdated Show resolved Hide resolved

src/NuGet.Clients/NuGet.VisualStudio.Common/Telemetry/TaskExtensions.cs Outdated Show resolved Hide resolved


          Update src/NuGet.Clients/NuGet.VisualStudio.Common/Telemetry/TaskExte…

70913be

…nsions.cs

Co-authored-by: Andy Zivkovic <[email protected]>

jgonz120 dismissed zivkan’s stale review via

70913be

January 3, 2025 18:59


          pr comments

8d6a530

zivkan previously approved these changes

View reviewed changes

jgonz120 mentioned this pull request

MEF Performance Improvement NuGet/Home#14027

Open

donnie-msft reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

src/NuGet.Clients/NuGet.VisualStudio.Common/Telemetry/TaskExtensions.cs Show resolved Hide resolved

src/NuGet.Clients/NuGet.VisualStudio.Common/Telemetry/TaskExtensions.cs Outdated Show resolved Hide resolved

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageManagerControl.xaml.cs Outdated Show resolved Hide resolved


          pr comments

ed62253

jgonz120 dismissed zivkan’s stale review via

ed62253

January 3, 2025 21:51


          Added IsReadmeTabEnable property to viewmodel

0ce3b5c

jgonz120 requested review from donnie-msft and zivkan

January 3, 2025 22:00

donnie-msft reviewed

View reviewed changes

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageManagerControl.xaml.cs Outdated Show resolved Hide resolved


          updated comment

98f97bb

jgonz120 requested a review from donnie-msft

January 3, 2025 23:26

donnie-msft previously approved these changes

View reviewed changes

Contributor

donnie-msft left a comment

Looks good!
The few design decisions that I think can be improved we discussed offline, and we agreed these can be handled in a future iteration.

Consider a bug bash early next week to help ensure there's no uncaught issues before GA.

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Outdated Show resolved Hide resolved

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs Show resolved Hide resolved

src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml Show resolved Hide resolved


          Update src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageRead…

3b5cef3

…meControl.xaml.cs

Co-authored-by: Donnie Goodson <[email protected]>

jgonz120 dismissed donnie-msft’s stale review via

3b5cef3

January 4, 2025 01:09

jgonz120 requested a review from donnie-msft

January 4, 2025 01:09

jgonz120 enabled auto-merge (squash)

January 4, 2025 01:10

donnie-msft approved these changes

View reviewed changes

jgonz120 merged commit 89781a2 into dev

20 of 23 checks passed

jgonz120 deleted the dev-jgonz120-UpdateMarkdownPreviewVersion branch

January 4, 2025 02:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

davkean davkean left review comments

donnie-msft donnie-msft approved these changes

Nigusu-Allehu Nigusu-Allehu left review comments

nkolev92 Awaiting requested review from nkolev92

jeffkl Awaiting requested review from jeffkl

zivkan Awaiting requested review from zivkan

Labels

None yet