TaskAPerms: move error reporting to top of file

for better debugging
NovemLinguae · Aug 24, 2024 · 7928dce · 7928dce
1 parent e571441
commit 7928dce
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/TaskAPerms/src/View.php b/TaskAPerms/src/View.php
@@ -14,11 +14,6 @@ public static function setHeaders() {
 		header( 'Content-Type:text/plain; charset=utf-8; Content-Encoding: none' );
 	}
 
-	public static function setErrorReporting() {
-		ini_set( "display_errors", 1 );
-		error_reporting( E_ALL );
-	}
-
 	public static function dieIfInvalidPassword( $correctPassword ) {
 		// Keep randos from running the bot in browser and in bash
 		$hasWrongWebPassword = ( $_GET['password'] ?? '' ) != $correctPassword;

diff --git a/TaskAPerms/src/index.php b/TaskAPerms/src/index.php
@@ -2,6 +2,9 @@
 
 // https://novem-bot.toolforge.org/task-a/index.php?password=
 
+ini_set( "display_errors", 1 );
+error_reporting( E_ALL );
+
 require_once 'botclasses.php';
 require_once 'Controller.php';
 require_once 'Database.php';
@@ -12,7 +15,6 @@
 require_once 'View.php';
 
 View::setHeaders();
-View::setErrorReporting();
 // set_time_limit(1440);    # 24 minutes
 
 View::dieIfInvalidPassword( $urlAndCliPassword );
@@ -56,4 +58,9 @@
 
 $c->writeUpdate();
 
+// Close PDO connections.
+unset( $enwiki );
+unset( $metawiki );
+unset( $centralauth );
+
 View::print( "\nMission accomplished.\n\n" ); // extra line breaks at end for CLI