For #152 - Remove serde_json dependency #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lars-t-hansen
force-pushed
the
w-152-serde_json
branch
from
cb077e8 to
9a33f81
Compare
lars-t-hansen
commented
Apr 4, 2024
src/sysinfo.rs
Outdated
| } | ||
|
|
||
| // Currently the test for do_show_system() is whitebox, see ../tests. The reason for this is partly |
There was a problem hiding this comment.
Mm, "whitebox" should be "blackbox" here.
lars-t-hansen
force-pushed
the
w-152-serde_json
branch
from
9a8a0f5 to
0963716
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes serde_json and the direct dependency on serde (though serde is still included indirectly via csv).