-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kristupas/update uniffi.0.28.0 #86
Draft
arg0d
wants to merge
8
commits into
main
Choose a base branch
from
kristupas/update-uniffi.0.28.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FWIW I am using this branch but I had to fix the namespace with this to compile and use the resulting csharp file |
Hey, this is a draft and not finished, I would recommend not using it yet. |
dfetti
force-pushed
the
kristupas/update-uniffi.0.28.0
branch
from
January 15, 2025 11:44
b485b2f
to
912a96e
Compare
Signed-off-by: Daniel Fetti <[email protected]>
Signed-off-by: Daniel Fetti <[email protected]>
Signed-off-by: Daniel Fetti <[email protected]>
Signed-off-by: Daniel Fetti <[email protected]>
Signed-off-by: Daniel Fetti <[email protected]>
Signed-off-by: Daniel Fetti <[email protected]>
Signed-off-by: Daniel Fetti <[email protected]>
SafeHandle is used to manage ownership of the Rust object. When SafeHandle goes out of scope, the underlying Rust reference is decremented. Method calls and lowering increment ("clone") object reference, and Rust is responsible for decrementing the reference. This means, it's not necessary to use SafeHandle directly for method calls and lowering, since Rust will take care of decrementing the reference. However, it's still necessary to use SafeHandle for "cloning" the reference, since CG may choose to collect the object itself and run the finalizer, in turn decrementing Rust reference and causing use-after-free during "clone" native call. (See SafeHandle documentation). Signed-off-by: Daniel Fetti <[email protected]>
dfetti
force-pushed
the
kristupas/update-uniffi.0.28.0
branch
from
January 15, 2025 11:49
912a96e
to
a438335
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.