Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the ffi constructor's type case issue (#28) #103

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Fix the ffi constructor's type case issue (#28) #103

merged 1 commit into from
Jan 15, 2025

Conversation

dfetti
Copy link
Contributor

@dfetti dfetti commented Jan 15, 2025 •
edited
Loading

This should fix issue #28

@dfetti dfetti requested a review from arg0d January 15, 2025 08:54
arg0d
arg0d previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@arg0d arg0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good. I would consider adding a short description in README.md in the new issue fixture.

@dfetti dfetti requested a review from arg0d January 15, 2025 09:29
@dfetti dfetti merged commit ee57bb3 into main Jan 15, 2025
3 checks passed
@dfetti dfetti deleted the issue-28 branch January 15, 2025 11:36
@dfetti dfetti mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arg0d arg0d arg0d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfetti @arg0d