Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add testFail JS integration test #655

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

agostbiro
Copy link
Member

@agostbiro agostbiro commented Sep 10, 2024

I originally added just a Rust unit test in #648 to make sure testFail is off by default when Solidity tests are ran through the JS interface. But that unit test failed to build on Ubuntu as the linker tried to link Node symbols into it for some reason. So I scrapped that Rust unit test and added JS integration tests here to make sure testFail is off by default.

Copy link

changeset-bot bot commented Sep 10, 2024

⚠️ No Changeset found

Latest commit: 5b22ff3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agostbiro agostbiro temporarily deployed to github-action-benchmark September 10, 2024 13:03 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark September 10, 2024 13:03 — with GitHub Actions Inactive
@agostbiro agostbiro requested a review from fvictorio September 10, 2024 13:03
@agostbiro agostbiro self-assigned this Sep 10, 2024
@agostbiro agostbiro added the no changeset needed This PR doesn't require a changeset label Sep 10, 2024
@agostbiro agostbiro added this to the Solidity tests, phase 2 milestone Sep 10, 2024
@agostbiro agostbiro temporarily deployed to github-action-benchmark September 10, 2024 19:34 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark September 10, 2024 19:34 — with GitHub Actions Inactive
Copy link
Member

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

A question: Was the linker error by any chance similar to this one?

@agostbiro
Copy link
Member Author

A question: Was the linker error by any chance similar to this one?

Yeah similar error. I didn't manage to resolve it in reasonable time.

Base automatically changed from test/isolate-mode-test to feat/solidity-tests September 12, 2024 15:03
@agostbiro agostbiro temporarily deployed to github-action-benchmark September 12, 2024 15:24 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark September 12, 2024 15:24 — with GitHub Actions Inactive
@agostbiro agostbiro merged commit d7c1472 into feat/solidity-tests Sep 12, 2024
18 checks passed
@agostbiro agostbiro deleted the test/fail-test branch September 12, 2024 15:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no changeset needed This PR doesn't require a changeset
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants