-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add testFail
JS integration test
#655
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
A question: Was the linker error by any chance similar to this one?
Yeah similar error. I didn't manage to resolve it in reasonable time. |
cc57a6d
to
5b22ff3
Compare
I originally added just a Rust unit test in #648 to make sure
testFail
is off by default when Solidity tests are ran through the JS interface. But that unit test failed to build on Ubuntu as the linker tried to link Node symbols into it for some reason. So I scrapped that Rust unit test and added JS integration tests here to make suretestFail
is off by default.