Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove usages of foundry-config from foundry-common #627

Merged
merged 2 commits into from
Aug 28, 2024
Merged

refactor: remove usages of foundry-config from foundry-common #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f93de8c
Remove EvmArgs
agostbiro Aug 26, 2024
e5bd54f
Use chains directly from Alloy
agostbiro Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 3 additions & 93 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions crates/foundry/common/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@ edition.workspace = true
[dependencies]
foundry-block-explorers = { workspace = true, features = ["foundry-compilers"] }
foundry-compilers.workspace = true
foundry-config.workspace = true
foundry-linking.workspace = true

alloy-chains.workspace = true
alloy-contract.workspace = true
alloy-consensus.workspace = true
alloy-dyn-abi = { workspace = true, features = ["arbitrary", "eip712"] }
alloy-json-abi.workspace = true
alloy-primitives = { workspace = true, features = ["serde", "getrandom", "arbitrary", "rlp"] }
Expand All @@ -24,13 +26,10 @@ alloy-transport-ipc.workspace = true
alloy-json-rpc.workspace = true
alloy-pubsub.workspace = true
alloy-sol-types.workspace = true
alloy-contract.workspace = true
alloy-consensus.workspace = true

tower.workspace = true

async-trait = "0.1"
clap = { version = "4", features = ["derive", "env", "unicode", "wrap_help"] }
comfy-table = "7"
dunce = "1"
eyre.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion crates/foundry/common/src/abi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

use std::{future::Future, pin::Pin};

use alloy_chains::Chain;
use alloy_dyn_abi::{DynSolType, DynSolValue, FunctionExt, JsonAbiExt};
use alloy_json_abi::{Event, Function};
use alloy_primitives::{hex, Address, LogData};
use eyre::{Context, ContextCompat, Result};
use foundry_block_explorers::{contract::ContractMetadata, errors::EtherscanError, Client};
use foundry_config::Chain;

/// Given a function and a vector of string arguments, it proceeds to convert
/// the args to alloy [`DynSolValue`]s and then ABI encode them.
Expand Down
Loading
Loading