Skip to content

Commit

Permalink
Remove usage of batch calls (#401)
Browse files Browse the repository at this point in the history
* Remove usage of batch calls

* Add macros feature to tokio dependency

* Remove unused code

* Create curly-ligers-crash.md

* Temporarily disable edr-benchmark workflow

* Remove obsolete test

* Run clippy with a normal step

* Fix clippy

* Add explanatory comment about disabled workflow
  • Loading branch information
fvictorio authored Apr 25, 2024
1 parent 82961e6 commit e82246c
Show file tree
Hide file tree
Showing 7 changed files with 77 additions and 293 deletions.
5 changes: 5 additions & 0 deletions .changeset/curly-ligers-crash.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nomicfoundation/edr": patch
---

Removed usage of batch calls to prevent 429 errors
4 changes: 3 additions & 1 deletion .github/workflows/edr-benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ jobs:
environment: github-action-benchmark
runs-on: self-hosted
# Only run for trusted collaborators since third-parties could run malicious code on the self-hosted benchmark runner.
if: github.ref == 'refs/heads/main' || (github.event.pull_request.author_association == 'OWNER' || github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'COLLABORATOR')
# Temporarily disabled after moving to our own repo; see https://github.com/NomicFoundation/edr/issues/402
# if: github.ref == 'refs/heads/main' || (github.event.pull_request.author_association == 'OWNER' || github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'COLLABORATOR')
if: false
steps:
- uses: actions/checkout@v3

Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/edr-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,7 @@ jobs:
args: --all --check

- name: Run cargo clippy
uses: auguwu/[email protected]
with:
token: ${{ secrets.GITHUB_TOKEN }}
all-features: true
check-args: --workspace --all-targets -- -Dwarnings
run: cargo clippy --workspace --all-targets --all-features -- -D warnings

edr-docs:
name: Build EDR Docs
Expand Down
2 changes: 1 addition & 1 deletion crates/edr_eth/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ serde = { version = "1.0.147", default-features = false, features = ["derive"],
serde_json = { version = "1.0.89", optional = true }
sha3 = { version = "0.10.8", default-features = false }
thiserror = { version = "1.0.37", default-features = false }
tokio = { version = "1.21.2", default-features = false, features = ["fs", "sync"] }
tokio = { version = "1.21.2", default-features = false, features = ["fs", "macros", "sync"] }
tracing = { version = "0.1.37", features = ["attributes", "std"], optional = true }
triehash = { version = "0.8.4", default-features = false }
uuid = { version = "1.4.1", default-features = false, features = ["v4"] }
Expand Down
Loading

0 comments on commit e82246c

Please sign in to comment.