Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

adds description and example for all the library methods and updates documentation in Readme file #11

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

Badrri-Narayanan
Copy link
Contributor

Description

Adds description and examples for all the library methods and also adds the same description and examples to the README file.

Issue ticket number and link

closes #10

Other stuff

After adding the description and examples, I ran the test suite and I observed the there was no breaking changes. Add the console logs below for reference.

$ npm run test

> @nodesecure/[email protected] test
> cross-env npm run lint && npm run test-only


> @nodesecure/[email protected] lint
> eslint --ext .js


> @nodesecure/[email protected] test-only
> cross-env esm-tape-runner 'test/*.spec.js' | tap-monkey

  🍌️ All tests passing!

  Total     97
  Passing   97
  Failing   0
  Duration  1.55 secs

Kindly let me know your review comments. Thanks!

Copy link
Member

@fraxken fraxken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fraxken fraxken merged commit 5a3c582 into NodeSecure:main Jan 15, 2023
@fraxken
Copy link
Member

fraxken commented Jan 15, 2023

@all-contributors please add @Badrri-Narayanan for doc

@allcontributors
Copy link
Contributor

@fraxken

I've put up a pull request to add @Badrri-Narayanan! 🎉

@fraxken
Copy link
Member

fraxken commented Jan 15, 2023

Thanks for the contribution! You'v done a nice work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve README (API documentation)
2 participants