Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: using dependabot groups #87

Merged
merged 1 commit into from
Feb 28, 2024
Merged

chore: using dependabot groups #87

merged 1 commit into from
Feb 28, 2024

Conversation

fabnguess
Copy link
Contributor

No description provided.

@fabnguess fabnguess requested a review from fraxken February 25, 2024 22:10
@PierreDemailly
Copy link
Member

PierreDemailly commented Feb 25, 2024

As disccused with @fabnguess, I wonder if we should have a 4th group for @nodesecure/* pattern.
For instance in this repository, we would have a group that update only @nodesecure/eslint-config & @nodesecure/npm-registry-sdk.
This 4th group would take both deps & devDeps (because @nodesecure/eslint-config is a devDep almost everywhere).
And we exclude the @nodesecure/* from the originals deps & devDeps groups.

WDYT @fraxken ?

Edit: we can also create this 4th group only for packages that have more @nodesecure dependencies like @nodesecure/cli, @nodesecure/scanner..

@fraxken
Copy link
Member

fraxken commented Feb 26, 2024

@PierreDemailly why not (but not sure if that's useful for all projects tho)

@PierreDemailly
Copy link
Member

Yeah only Cli & Scanner should be fine

@fraxken fraxken merged commit 4eaeb6a into main Feb 28, 2024
5 checks passed
@fraxken fraxken deleted the dependabot_groups branch March 10, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants