Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create new header menu #283

Merged
merged 1 commit into from
Nov 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions public/css/components/package/header.css
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,38 @@ div.package-head-information>.package-name>.version {
display: flex;
align-items: end;
}
div.package-head-information>.package-name>.info {
background: url("../../../img/arrow-right-solid.svg");
background-position: center center;
background-repeat: no-repeat;
width: 18px;
height: 22px;
border: none;
margin-left: auto;
cursor: pointer;
/* https://codepen.io/sosuke/pen/Pjoqqp */
filter: invert(71%) sepia(22%) saturate(6942%) hue-rotate(149deg) brightness(101%) contrast(106%);
}
div.package-head-information>.package-name>.info-menu {
background: #f7f7f7;
padding: 16px;
border: none;
border-radius: 6px;
position: absolute;
left: 420px;
width: 160px;
text-shadow: none;
}
div.package-head-information>.package-name>.info-menu>.info-menu-title {
font-weight: bold;
text-align: center;
margin-bottom: 12px;
color: rgb(39, 38, 38);
}
div.package-head-information>.package-name>.info-menu>a {
display: block;
margin-bottom: 4px;
}

div.package-head-information>ul.package-flags {
display: flex;
Expand Down
2 changes: 1 addition & 1 deletion public/css/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,6 @@ main {
left: 0;
top: 0;
}
main > section.content .view.hidden {
main .hidden {
display: none;
}
1 change: 1 addition & 0 deletions public/img/arrow-right-solid.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
70 changes: 40 additions & 30 deletions public/js/components/package/header.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,10 @@ export class PackageHeader {
flags
} = this.package.dependencyVersion;

const [nameDomElement, versionDomElement, descriptionDomElement, linksDomElement, flagsDomElement] = [
const [nameDomElement, versionDomElement, menuDomElement, descriptionDomElement, linksDomElement, flagsDomElement] = [
clone.querySelector(".name"),
clone.querySelector(".version"),
clone.querySelector(".info"),
clone.querySelector(".package-description"),
clone.querySelector(".package-links"),
clone.querySelector(".package-flags")
Expand All @@ -43,6 +44,20 @@ export class PackageHeader {
}
versionDomElement.textContent = `v${packageVersion}`;

// Menu
const menu = this.renderMenu(packageName);
menuDomElement.insertAdjacentElement("afterend", menu);
menuDomElement.addEventListener("click", () => {
const menu = menuDomElement.parentNode.querySelector(".info-menu");
if (menu.classList.contains("hidden")) {
menu.classList.remove("hidden");
}
else {
menu.classList.add("hidden");
}
utils.hideOnClickOutside(menu, [menuDomElement]);
});

// Description
const description = packageDescription.trim();
if (description === "") {
Expand Down Expand Up @@ -89,12 +104,6 @@ export class PackageHeader {
icon: "icon-vcard",
showInHeader: true
},
thirdParty: {
menu: this.renderToolsMenu(packageName),
text: 'Tools',
icon: 'icon-link',
showInHeader: true
}
};
linksDomElement.appendChild(this.renderLinks(links));

Expand Down Expand Up @@ -159,31 +168,32 @@ export class PackageHeader {
* @param {!string} packageName
* @returns {HTMLElement[]}
*/
renderToolsMenu(packageName) {
renderMenu(packageName) {
const { snykAdvisor, socket } = PackageHeader.ExternalLinks;

return [
utils.createDOMElement('span', { text: 'Tools' }),
utils.createDOMElement('div', {
classList: ['tools-menu'],
childs: [
utils.createDOMElement('a', {
text: 'Snyk',
attributes: {
href: snykAdvisor + packageName,
target: "_blank",
}
}),
utils.createDOMElement('a', {
text: 'Socket.dev',
attributes: {
href: socket + packageName,
target: "_blank",
}
})
]
})
]
return utils.createDOMElement('div', {
classList: ['info-menu', 'hidden'],
childs: [
utils.createDOMElement("div", {
text: "Third-party tools",
classList: ['info-menu-title'],
}),
utils.createDOMElement('a', {
text: 'Snyk',
attributes: {
href: snykAdvisor + packageName,
target: "_blank",
}
}),
utils.createDOMElement('a', {
text: 'Socket.dev',
attributes: {
href: socket + packageName,
target: "_blank",
}
})
]
});
}

renderFlags(flags) {
Expand Down
15 changes: 15 additions & 0 deletions public/js/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -322,3 +322,18 @@ export function copyToClipboard(str) {
document.getSelection().addRange(selected); // Restore the original selection
}
};

export function hideOnClickOutside(element, blacklistElements = []) {
const outsideClickListener = (event) => {
if (!element.contains(event.target) && !blacklistElements.includes(event.target)) {
element.classList.add("hidden");
removeClickListener();
}
}

const removeClickListener = () => {
document.removeEventListener('click', outsideClickListener);
}

document.addEventListener('click', outsideClickListener);
}
1 change: 1 addition & 0 deletions views/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@ <h1><i class="icon-cog"></i>General</h1>
<div class="package-name">
<p class="name"></p>
<p class="version"></p>
<button class="info"></button>
</div>
<p class="package-description"></p>
<ul class="package-flags"></ul>
Expand Down