feat: ignore warnings via .nsci-ignore file
#7
Conversation
|
Definitely not my definitive version, but I'd like to have the first review. |
tony-go
force-pushed
the
feature/nsci-ignore
branch
from
0b1fca4 to
02e0458
Compare
|
Made corrections cc @antoine-coulon Let's add e2e tests now, and enrich existing ones. Then we should be good for milestone 1. |
LGTM |
|
I'll make a finally review, to see if I didn't have duplicated stuff, magic numbers etc... Before that I have two remaining question marks:
|
You're completely right, I would go for the latest one,
In my humble opinion it's fine to directly use reporting utils instead of creating a dedicated reporter abstracting that, as it appears that the logged stuff is really light. However for the output part in the context of tests you're right, it should not appear. One way of fixing without two much overhead would be using some sort of dependency injection directly in the Ideally, this should be done at an higher application level to control and inject all other reporters the same way but it's clearly out of the scope of the PR. |
|
Finally ready for the big jump @antoine-coulon |
parent 4f7b4ef author Tony Gorez <[email protected]> 1654807466 +0200 committer Tony Gorez <[email protected]> 1656869571 +0200 feat: add getIngoreFile fn chore: delete di and use mock-fs feat: make validator return error fix: root path feat: add base filter fix: types chore(interpret): create hasWarningsIgnorePatterns func chore(adapt): fix import) fix(adapt): dont return ignorePatterns fix(ignore-file): add jsxray types fix: use process.cwd() fix: use IgnorePatterns.default instead of creating manual object fix: lint + use IgnorePatterns.default fix: standardizeExternalConfiguration type chore: rename filter function chore: rename a few variables/func/types test: move test and fix types chore: apply linter chore(interpret): add fixture generators chore: rename ignore file fix: create temporary logger abstract chore: apply linter doc: add .nodesecureignore base doc fix: IgnorePatterns & IgnoreWarningsPatterns abstract
|
@all-contributors please add @tony-go for code, doc |
|
I've put up a pull request to add @tony-go! 🎉 |
parent 4f7b4ef author Tony Gorez <[email protected]> 1654807466 +0200 committer Tony Gorez <[email protected]> 1656869571 +0200 feat: add getIngoreFile fn chore: delete di and use mock-fs feat: make validator return error fix: root path feat: add base filter fix: types chore(interpret): create hasWarningsIgnorePatterns func chore(adapt): fix import) fix(adapt): dont return ignorePatterns fix(ignore-file): add jsxray types fix: use process.cwd() fix: use IgnorePatterns.default instead of creating manual object fix: lint + use IgnorePatterns.default fix: standardizeExternalConfiguration type chore: rename filter function chore: rename a few variables/func/types test: move test and fix types chore: apply linter chore(interpret): add fixture generators chore: rename ignore file fix: create temporary logger abstract chore: apply linter doc: add .nodesecureignore base doc fix: IgnorePatterns & IgnoreWarningsPatterns abstract
Resolve issue #4 (Milestone 1).
You'll be able to ignore warnings with a
.nsci-ignorefile:{ "warnings": { "unsafe-stmt": ["lodash.difference", "regenerator-runtime"] } }