Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Recurrent predictions #1285

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

elephaint
Copy link
Contributor

@elephaint elephaint commented Mar 9, 2025

When setting recurrent=True in recursive models (LSTM, GRU, RNN) there is a bug that ignores the latest available ground truth in the forecast (i.e., off-by-one error). This makes forecasts slightly worse, thus fixing the bug improves forecast quality when making forecasts with recursive=True.

@elephaint elephaint added the bug label Mar 9, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@elephaint elephaint requested a review from marcopeix March 9, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant