Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: We added the horizon weighing to the distribution losses, simil… #1233

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

mwamsojo
Copy link
Contributor

We suggest modifying the distribution loss class to include the weighting option for distribution losses (to be similar to point losses)

  • We pass the horizon weight vector when initializing the losses
  • We add a function to check and apply the weights according to the mask

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Dec 18, 2024

CLA assistant check
All committers have signed the CLA.

@mwamsojo mwamsojo force-pushed the Weighted-Horizons-Distribution-Loss branch from bb41743 to f2c957e Compare December 19, 2024 14:02
@mwamsojo mwamsojo force-pushed the Weighted-Horizons-Distribution-Loss branch from 2d39cfa to 3840b2c Compare January 20, 2025 09:41
…r to point losses like MAE. This has proven useful in our applications. Also cleaning notebook outputs.
@mwamsojo mwamsojo force-pushed the Weighted-Horizons-Distribution-Loss branch from 3840b2c to e551e4d Compare January 21, 2025 09:53
@marcopeix marcopeix self-requested a review January 22, 2025 19:10
Copy link
Contributor

@marcopeix marcopeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcopeix marcopeix merged commit 5ebaa22 into Nixtla:main Jan 22, 2025
13 checks passed
@elephaint elephaint mentioned this pull request Jan 31, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants