Review: simplify the assginment

Nixtla · Dec 16, 2024 · 8d213a6 · 8d213a6
1 parent 0ad8caa
commit 8d213a6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/nbs/core.ipynb b/nbs/core.ipynb
@@ -1549,8 +1549,8 @@
     "        }\n",
     "        for attr in ['prediction_intervals', '_cs_df']:\n",
     "            # conformal prediction related attributes was not available < 1.7.6\n",
-    "            if hasattr(self, attr):\n",
-    "                config_dict[attr] = getattr(self, attr, None)\n",
+    "            config_dict[attr] = getattr(self, attr, None)\n",
+    "            \n",
     "\n",
     "        if save_dataset:\n",
     "            config_dict.update(\n",
@@ -1651,8 +1651,7 @@
     "            setattr(neuralforecast, attr, config_dict.get(attr, default))\n",
     "        # only restore attribute if available\n",
     "        for attr in ['prediction_intervals', '_cs_df']:\n",
-    "            if attr in config_dict.keys():\n",
-    "                setattr(neuralforecast, attr, config_dict[attr])\n",
+    "            setattr(neuralforecast, attr, config_dict.get(attr, None))\n",
     "\n",
     "        # Dataset\n",
     "        if dataset is not None:\n",

diff --git a/neuralforecast/core.py b/neuralforecast/core.py
@@ -1537,8 +1537,7 @@ def save(
         }
         for attr in ["prediction_intervals", "_cs_df"]:
             # conformal prediction related attributes was not available < 1.7.6
-            if hasattr(self, attr):
-                config_dict[attr] = getattr(self, attr, None)
+            config_dict[attr] = getattr(self, attr, None)
 
         if save_dataset:
             config_dict.update(
@@ -1644,8 +1643,7 @@ def load(path, verbose=False, **kwargs):
             setattr(neuralforecast, attr, config_dict.get(attr, default))
         # only restore attribute if available
         for attr in ["prediction_intervals", "_cs_df"]:
-            if attr in config_dict.keys():
-                setattr(neuralforecast, attr, config_dict[attr])
+            setattr(neuralforecast, attr, config_dict.get(attr, None))
 
         # Dataset
         if dataset is not None: